brave-intl/bat-native-confirmations

bat-native-confirmations's Issues

Library should adhere to const correctness

Confirm user has sustained viewing an Ad

Subtasks

• Implement AdSustained
• Refactor to use AdSustained to reward end user

Require a public key in confirmation token response

We need this in order to distinguish the cases of:

1. The client has an outdated public key from the server because they're using a stale catalog.
2. The server is lying to the client about what public key was used to sign tokens, which would enable the client to deanonymize clients.

https://github.com/brave/ads-serve/issues/103

Changes to how unblind and BatchDLEQProof::verify are being called in challenge-bypass-ristretto-ffi

As part of the security review against challenge-bypass-ristretto-ffi Token::unblind and BatchDLEQProof::verify were combined to make the library more misuse resistant.

The the combined function looks like:
pub fn verify_and_unblind(tokens: &[Token], signed_tokens: &[SignedToken], proof: BatchDLEQProof, public_key: PublicKey) -> Vec<UnblindedToken>

We need to change the calling code to accommodate.

Add support for VLOG to help reduce noise in logs for INFO

Speaking with @NejcZdovc and @bridiver we should create a separate VLOG macro (with Chromium matching log levels) in bat-native-confirmations that proxies back to the client. See LOG macro for implementation.

Ads Serve failures should retry

Inform Confirmations issuers have changed in the Ads Serve Catalog

Subtasks:

• Implement IssuersInfo
• Implement SetCatalogIssuers
• Refactor get_catalog to use IssuersInfo provided to SetCatalogIssuers

Implement logging

Implement Log as a proxy to bat-native-ledger Log

Confirmations implementation

initiating profile DCHECK failure

fixes brave-intl/bat-native-ads#117

If catalog is stale user may not be rewarded for viewing an Ad

If the public key fails to validate in the following code:

// Validate public key
  auto catalog_issuers = confirmations_->GetCatalogIssuers();

  auto iterator = catalog_issuers.find(public_key_base64);
  if (iterator == catalog_issuers.end()) {
    BLOG(ERROR) << "Response public_key: " << public_key_base64
        << " was not found in the catalog issuers";
    OnRedeem(FAILED);
    return;
  }
  auto issuer_name = iterator->second;

then a user may not be rewarded for viewing an Ad if the Catalog is stale as OnRedeem(FAILED) removes the unblinded token and does not try again

Implement timers

Subtasks:

• Implement OnTimer as a proxy to bat-native-ledger OnTimer
• Refactor to use OnTimer to trigger events based up on spec
• Implement SetTimer as a proxy to bat-native-ledger SetTimer
• Refactor to use SetTimer to schedule events based up on spec
• Implement KillTimer as a proxy to bat-native-ledger KillTimer
• Refactor to use KillTimer to unschedule events based up on spec

Refactor MockServer class to use Google Mocks

Remove any sensitive information from diagnostic logs before security review

Add support for both staging and production Ads Serve URLs

Add support for both staging and production Ads Serve URLs based upon _is_production boolean flag

Confirm if Ad can be shown

Implement CanShowAd by refactoring confirmations_ready_for_ad_showing

Implement Client public facing interface

Remove Challenge Bypass Ristretto Git sub-module and add as a Brave Core build dependency

Remove static/global variables from implementation

Add unit tests

Persist confirmations state

Determine how often we should redeem payment tokens

Determine how often we should redeem payment tokens. Currently set to browser startup and once per day thereafter with no jitter.

Refactor and remove duplicate code

Confirmations fails to initialize when creating a new wallet

Confirmations fails to initialize when creating a new wallet. Restarting browser resolves issue.

Integrate command-line switches into Brave Core for Confirmations

Automate building of Challenge Bypass Ristretto using Rust

Integrate BAT Native Confirmations into Brave Core

Update README.md

Refactor HappyHTTP to use net:URLFetcher

Subtasks:

• Refactor HappyHTTP to use net::URLFetcher
• Refactor net::URLFetcher calls to be synchronous
• URLRequests should retry if not successful

Refactoring: Challenge Bypass Ristretto FFI tokens should be raw objects instead of strings in function parameters

I need to investigate further and then work with eV to make possible changes to Challenge Bypass Ristretto FFI

Fix unit test build errors

Persist and reset Confirmations state

Subtasks:

• Implement Save as a proxy to bat-native-ledger Save
• Implement Load as a proxy to bat-native-ledger Load
• Implement Reset as a proxy to bat-native-ledger Reset

Improve logging to help diagnose issues

Update Confirmations wallet information

Subtasks:

• Implement WalletInfo data structure, see WALLET_INFO_ST in bat-native-ledger for data structure
• Implement SetWalletInfo
• Refactor to use WalletInfo provided to SetWalletInfo

Refactor codebase to address security issues and to help with future change requests

Implement client mock for unit tests

Confirm and remove commented out code

Implement client implementation

URLRequests should retry if not successful

Confirmations steps crash if invalid values are passed

Confirmations steps crash if invalid values are passed, i.e. empty wallet_info data structure

Confirm if we should prune fully submitted payment bundles as the list will grow based upon # of ads watched & paid

Add support for _is_production flag to choose between production and staging environments

Implement public facing interface

Implementation should adhere to coding standards

Initialize Confirmations

Subtasks:

• Implement initialization
• Refactor Initialize to use real data as currently initializes tests

Add Travis CI

Parse Catalog issuers

Add diagnostic logging for all success and failure paths

Implement unit tests

Refactor code to use callbacks for each confirmation state