Support sync

[brave]

Support sync

[cezaraugusto]

[bsclifton]

@chantisnake code has been merged- it's live in development channel (although, we're due for a build). It currently points at a staging environment and is hidden behind a command line flag. According to our release schedule, 0.57.x is due to be released ~Dec 4th

[SergeyZhukovsky]

Nice art!!! :)

[AlexeyBarabash]

Here is a current status

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [] (1) organize dependancy in git 

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [] (1) simple page for sync settings // in progress
   [] (5) QR code way for mobile devices
   [] (?) pretty Brave-styled UI

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests 

[bbondy]

@AlexeyBarabash could you provide a new update similar to the one from Jun 15th?

[AlexeyBarabash]

@bbondy

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [N/A] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [N/A] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [N/A] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [+] (1) organize dependancy in git 
   [] run sync-js as a extension background page
      [+] (1) Brave Sync Extension
      [+] (2) BraveSyncClient interface
      [+] (3) Brave Sync Extension resources packing // done by @bridiver
      [] (3) js-sync-lib methods with strict arguments on call execution browser<=>extension // in progress

[+/-] Objects synchronization
   [+/-] (3) bookmarks
     [] (5) ordering
   [+] devices
   [] (3) history
   [] (3) settings

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [+] (1) simple page for sync settings 
   [+] (5) QR code way for mobile devices
   [+] (1) secret words way for desktops
   [] (?) pretty Brave-styled UI // in progress by @cezaraugusto

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests 

[AlexeyBarabash]

@bbondy

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [N/A] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [N/A] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [N/A] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [+] (1) organize dependancy in git 
   [+] run sync-js as a extension background page
      [+] (1) Brave Sync Extension
      [+] (2) BraveSyncClient interface
      [+] (3) Brave Sync Extension resources packing // done by @bridiver
      [+] (3) js-sync-lib methods with strict arguments on call execution browser<=>extension 

[] Misc
   [] (1) per-profile sync // in progress
   [] (3) threading
   [+] (1) rebase to cr70

[+/-] Objects synchronization
   [+/-] (3) bookmarks
     [] (5) ordering
   [+] devices
   [] (3) history
   [] (3) settings

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [+] (1) simple page for sync settings 
   [+] (5) QR code way for mobile devices
   [+] (1) secret words way for desktops
   [] (?) pretty Brave-styled UI // in progress by @cezaraugusto

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests 

[AlexeyBarabash]

current update

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [N/A] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [N/A] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [N/A] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [+] (1) organize dependancy in git 
   [+] run sync-js as a extension background page
      [+] (1) Brave Sync Extension
      [+] (2) BraveSyncClient interface
      [+] (3) Brave Sync Extension resources packing // done by @bridiver
      [+] (3) js-sync-lib methods with strict arguments on call execution browser<=>extension 

[] Misc
   [+] (1) per-profile sync
   [+] (3) threading
   [+] (1) rebase to cr70

[+/-] Objects synchronization
   [+/-] (3) bookmarks
     [] (5) ordering // in progress
   [+] devices
   [] (3) history
   [] (3) settings

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [+] (1) simple page for sync settings 
   [+] (5) QR code way for mobile devices
   [+] (1) secret words way for desktops
   [] (?) pretty Brave-styled UI // in progress by @cezaraugusto

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests 

[czhang03]

Is sync expected in version 1.x or version 0.57?

[bbondy]

0.57.x however we are only putting issues in milestones once they are merged.

[czhang03]

Can we get an update on this please? I can't wait to see the progress on this one.

[bbondy]

0.57.x will have sync behind a command line flag that you need to specify to see the UI. For 0.58.x we'll remove the need for the command line flag.

[rahilwazir]

@bbondy @bsclifton

How am I suppose to use sync feature?

Running Version 0.58.9 Chromium: 71.0.3578.53 (Official Build) dev (64-bit)

[bsclifton]

@rahilwazir that section is confusing and we want to rename / move that section (this was previously called Privacy and security settings but we renamed/moved with Chromium 71). It should be on @rebron 's radar- but I don't think we have an issue captured yet. In Chrome / Chromium, you can enable Google sync there (but it doesn't show in Brave because we intentionally removed it)

The only way to enable sync (Brave Sync) at the moment is to pass in the command line flag --enable-brave-sync when launching Brave. You should then see a new item in the hamburger menu where you can activate it 😄

[srirambv]

Verification passed on

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux

• Verified Sync option available in hamburger menu
• Verified settings has a dedicated section for sync which redirects to brave://bravesync
  
• Verified able to create a new sync chain
• Verified able to join an existing sync chain
• Verified able to reset and recreate a new sync chain
• Verified able to remove other devices joined in sync chain
• Verified able to sync bookmarks to other devices
• Verified able to sync bookmarks added on other devices

Verification passed on

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows

• Verified Sync option available in hamburger menu
• Verified settings has a dedicated section for sync which redirects to brave://bravesync
  
• Verified able to create a new sync chain
• Verified able to join an existing sync chain
• Verified able to reset and recreate a new sync chain
• Verified able to remove other devices joined in sync chain
• Verified able to sync bookmarks to other devices
• Verified able to sync bookmarks added on other devices

Verified passed with

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

• Verified Sync option available in hamburger menu
• Verified settings has a dedicated section for sync which redirects to brave://bravesync
• Verified able to create a new sync chain
• Verified able to join an existing sync chain
• Verified able to reset and recreate a new sync chain
• Verified able to remove other devices joined in sync chain
• Verified able to sync bookmarks to other devices
• Verified able to sync bookmarks added on other devices