Giter Site home page Giter Site logo

Comments (2)

simonhong avatar simonhong commented on July 18, 2024

checking.

from brave-browser.

simonhong avatar simonhong commented on July 18, 2024

When SidePanelCoordinator tries to removing observation for de-activated tab's SidePanelRegistry, this crash happened. We call it contextual registry as it is per-tab context registry.
The crash reason is observer list doesn't contain that deactivated tab's `registry at that time.

SidePanelCoordinator starts to observe tab's registry when tab is activated.
and remove observation when tab is de-activated.

There are two points that stop observation.

  • SidePanelCoordinator::OnRegistryDestroying() - when observed registry is destroyed
  • SidePanelCoordinator::OnTabStripModelChanged() - when tab is deactivated

To make this crash happens, I think active tab's SidePanelRegistry should be destroyed while its tab is still active.
As SidePanelRegistryset as WebContents' UserData, its life cycle is tied with WebContents.
Well.. I think this case would not be happened.

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.