Comments (4)
I think the original intention was for users to keep track of the FileId
themselves, and use that to refer to and update files, but I understand that might be a bit confusing for people. Yet another reason why I think that maintaining our own file database is a bad ideaβ¦ I think we should support single file reporting easily out of the box, and have an example of how to extend this to work with multiple files, but that's it. That way people can customise things to their use case π€
from codespan.
Well, I could be including the same file more than once, if this wasn't part of codespan I'd have to implement it myself. e.g.
main.c
:
#include <stdio.h>
#include <limits.h>
stdio.h
: #include <limits.h>
from codespan.
Now that the Files trait exists as of #164 users should be implement their own solutions and decide if they need deduplication or not, but I agree that supporting single file use cases would be very nice (especially for codespan-lsp
since there a simple Vec for a file database wouldn't really cut it).
A bit unrelated, but I think it would be better if it was in the codespan
crate, so if I only use codespan
and codespan-lsp
I don't need codespan-reporting
. I'm working on a language server with tree-sitter and I need a way to convert points to byte positions for Tree::edit().
from codespan.
I'm going to say that this should be handled in a custom implementation of codespan_reporting::Files
. I've tried to make implementing these relatively painless, but if you think I can do better, let me know!
For users of codespan
, you can use the Files::update
function to update files in-place. You will have to keep a hold of the FileId
though - the file name is used purely for display purposes.
from codespan.
Related Issues (20)
- Add an option to render more context around lines. HOT 11
- Order-preserving error reporting HOT 1
- Position is off by 2 characters with some strings HOT 6
- Add the ability to make multiline suggestions/notes HOT 4
- release tracking issue HOT 5
- codespan-reporting::Files not implemented for codespan::Files<String> HOT 3
- Display is broken on some platforms HOT 5
- Should non-`term` rendering backends live here? HOT 1
- Cut codespan release with fix? HOT 5
- Use of moved value: `blue` HOT 4
- Accessor for the location of a diagnostic HOT 3
- Implement `Ord` for `Severity` HOT 3
- Are there C bindings for codespan? HOT 2
- How to report inside `Display` implementation? HOT 3
- The destiny of `codespan` (and `codespan-reporting`)
- Make some functions `const`
- Request a new releases for including context before and after a label HOT 6
- Error when an error spans until EOF
- Wrong outer padding
- Move termcolor behind a feature flag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codespan.