Giter Site home page Giter Site logo

Comments (4)

Marwes avatar Marwes commented on May 25, 2024 1

Getting some sort of trait in would be nice before upgrading for me as the lack of being able to take individual Arc<FileMap> out makes it impossible to work with Files concurrently (reading from one file while adding others).

I can take https://github.com/brendanzab/codespan/compare/traits and get it working but I don't really know if we must/should make any additional changes to the traits.

from codespan.

brendanzab avatar brendanzab commented on May 25, 2024

Inching towards a Files trait here: https://github.com/brendanzab/codespan/compare/traits

Still does not compile though - working through how to pull everything out nicely. The crate structure is a tad awkward though - now codespan is only depended on in order to implement Span and Files.

from codespan.

brendanzab avatar brendanzab commented on May 25, 2024

I think it'd probably also be nice to implement the LSP support in terms of these traits too.

from codespan.

brendanzab avatar brendanzab commented on May 25, 2024

It would also be interesting if we could have a subtrait that also provided URLs for codespan-lsp, which would mean we wouldn't have to supply the correlate_file_url closure.

from codespan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.