Giter Site home page Giter Site logo

Comments (3)

matklad avatar matklad commented on May 25, 2024 2

One additional concern here is how to translate between BytePos -> LineCol coordinates in the presence of edits. In rust-analyzer, we hit this in the following case:

  • our internal coordiantes are byte offsets
  • the result of the refactoring is a set of edits (in byte-offset coordinates) and a final position of a curosr (byte offset in a file with changes)
  • on the LSP layer, we need to translate this to (line, col) coordinates. Doing this for cursor offset is tricky.

This PR implements that logic: rust-lang/rust-analyzer#325

Additional random tidbit:

I was surprised that IntelliJ uses sorted array of offsets and not some fancy tree data structure, a-la xi-rope's monoid tree, to translate offsets: https://github.com/JetBrains/intellij-community/blob/513e5d6cdaa66c93e130393045bcc038537454d3/platform/core-impl/src/com/intellij/openapi/editor/impl/LineSet.java

In particular, they just update the array on changes: https://github.com/JetBrains/intellij-community/blob/513e5d6cdaa66c93e130393045bcc038537454d3/platform/core-impl/src/com/intellij/openapi/editor/impl/LineSet.java#L70-L94

IIUC, for things like grapheme clusters IntelliJ doesn't use indices at all, and instead does a linear scan withing a single line.

from codespan.

brendanzab avatar brendanzab commented on May 25, 2024 1

Thanks for the added information, that's really helpful!

from codespan.

brendanzab avatar brendanzab commented on May 25, 2024

Gonna close this because now user's can implement their own file databases using the Files trait.

from codespan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.