Comments (3)
One additional concern here is how to translate between BytePos -> LineCol coordinates in the presence of edits. In rust-analyzer, we hit this in the following case:
- our internal coordiantes are byte offsets
- the result of the refactoring is a set of edits (in byte-offset coordinates) and a final position of a curosr (byte offset in a file with changes)
- on the LSP layer, we need to translate this to (line, col) coordinates. Doing this for cursor offset is tricky.
This PR implements that logic: rust-lang/rust-analyzer#325
Additional random tidbit:
I was surprised that IntelliJ uses sorted array of offsets and not some fancy tree data structure, a-la xi-rope's monoid tree, to translate offsets: https://github.com/JetBrains/intellij-community/blob/513e5d6cdaa66c93e130393045bcc038537454d3/platform/core-impl/src/com/intellij/openapi/editor/impl/LineSet.java
In particular, they just update the array on changes: https://github.com/JetBrains/intellij-community/blob/513e5d6cdaa66c93e130393045bcc038537454d3/platform/core-impl/src/com/intellij/openapi/editor/impl/LineSet.java#L70-L94
IIUC, for things like grapheme clusters IntelliJ doesn't use indices at all, and instead does a linear scan withing a single line.
from codespan.
Thanks for the added information, that's really helpful!
from codespan.
Gonna close this because now user's can implement their own file databases using the Files
trait.
from codespan.
Related Issues (20)
- Add an option to render more context around lines. HOT 11
- Order-preserving error reporting HOT 1
- Position is off by 2 characters with some strings HOT 6
- Add the ability to make multiline suggestions/notes HOT 4
- release tracking issue HOT 5
- codespan-reporting::Files not implemented for codespan::Files<String> HOT 3
- Display is broken on some platforms HOT 5
- Should non-`term` rendering backends live here? HOT 1
- Cut codespan release with fix? HOT 5
- Use of moved value: `blue` HOT 4
- Accessor for the location of a diagnostic HOT 3
- Implement `Ord` for `Severity` HOT 3
- Are there C bindings for codespan? HOT 2
- How to report inside `Display` implementation? HOT 3
- The destiny of `codespan` (and `codespan-reporting`)
- Make some functions `const`
- Request a new releases for including context before and after a label HOT 6
- Error when an error spans until EOF
- Wrong outer padding
- Move termcolor behind a feature flag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codespan.