Comments (5)
Hello @BrentAureli
The following patch should solve the problem :
Index: core/src/com/brentaureli/mariobros/Sprites/Mario.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- core/src/com/brentaureli/mariobros/Sprites/Mario.java (date 1445566359000)
+++ core/src/com/brentaureli/mariobros/Sprites/Mario.java (revision )
@@ -200,10 +200,12 @@
}
public void grow(){
+ if( !isBig() ) { // @SuperMario#3
- runGrowAnimation = true;
- marioIsBig = true;
- timeToDefineBigMario = true;
- setBounds(getX(), getY(), getWidth(), getHeight() * 2);
+ runGrowAnimation = true;
+ marioIsBig = true;
+ timeToDefineBigMario = true;
+ setBounds(getX(), getY(), getWidth(), getHeight() * 2);
+ } // @SuperMario#3
MarioBros.manager.get("audio/sounds/powerup.wav", Sound.class).play();
}
Regards,
M
from supermario.
Hey M! Thanks so much for the issue reports! There is currently many issues that could be resolved however the series has been completed. I didn't polish off the code because the major points had already been discussed during the series and all future videos would have just been review. See final video here: https://www.youtube.com/watch?v=EIYIh_WXqNw
If you would like to make any changes/fixes yourself please feel free to submit a pull request! I'll accept it!
from supermario.
Hello @BrentAureli,
Thanks for you answer.
I already watched your video but i thought that there was still room for improvment so i reported some of the bugs i noticed.
I'll gladly contribute back but i don't feel really confortable with git.
Do you know a good video tutorial ?
Regards,
M
from supermario.
Im not sure of a good video tutorial but this may help!
https://www.atlassian.com/git/tutorials/syncing/git-pull
from supermario.
Hello @BrentAureli ,
I think this issue is fixed.
Regards,
M
from supermario.
Related Issues (16)
- Mario is flying HOT 2
- Points animation
- Camera movement
- Refactoring - use State Design Pattern
- Refactoring - use Command Design Pattern
- Unable to find region from badlogic HOT 2
- no suitable method found for setRegion(Object) HOT 5
- Timer countdown doesn't work properly HOT 2
- Clearing enemy issue
- Not Working
- Design Mario's win and go to the next stage
- Mario doesn't die when falling in a pit
- Breaking a block
- Hitting a block
- Enemy point chart
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from supermario.