brentaureli/supermario

Source Code from my Creating Super Mario Bros YouTube Tutorials

SuperMario

YouTube Tutorials @ http://www.BrentAureli.com

supermario's Issues

Refactoring - use Command Design Pattern

Hello @BrentAureli,

I think it would also be a real improvement to the code using the Command Design Pattern as it is explained here : http://gameprogrammingpatterns.com/command.html

Regards,
M

Mario is flying

If you hit the up key several times, Mario jumps repeatedly and consequently flies.

Not Working

None of these files work any more... very frustrating.

Design Mario's win and go to the next stage

How does Mario finish the game and go to the next stage?

Hitting a block

When Mario is small and hits a block, the block doesn't break but bounces.
The block bouncing animation should be implemented.

Enemy point chart

According to this document ( http://themushroomkingdom.net/smb_breakdown.shtml ), the point value for given after killing an enemy is not correct (see Enemy point chart paragraph).

Camera movement

According to this video ( http://www.youtube.com/watch?v=rc62hFksKo4 ) the camera only moves forward.

Timer countdown doesn't work properly

The world timer doesn't stop when it reaches 0.
And Mario doesn't die when world time equals 0.

Points animation

According to this video ( http://www.youtube.com/watch?v=rc62hFksKo4 ) when Mario hits an enemy, a label with the points value is displayed above the enemy position and animated for a short period of time.

Mario can grow multiple times

If you get the first mushroom at the beginning of the level and get the second one at the end of the level without being hit by an enemy, mario grows 2 times.

Refactoring - use State Design Pattern

Hello @BrentAureli,

I think it would be a real benefit to refactor the Mario Class using the State Design Pattern as it is explained here : http://gameprogrammingpatterns.com/state.html

Regards,
M

Unable to find region from badlogic

In the code snippet below, it says incompatible types for region where i have marked asterisk, for some reason it only recognises it as java.lang.object.

public TextureRegion getFrame(float dt){
currentState = getState();

    TextureRegion region;
    switch(currentState){
        case JUMPING:
            region = marioJump.getKeyFrame(stateTimer);  ***********
            break;
        case RUNNING:
            region = marioRun.getKeyFrame(stateTimer, true); ***********
            break;
        case FALLING:
        case STANDING:
        default:
            region = marioStand;
            break;
    }

Breaking a block

The breaking of a block should be animated.

no suitable method found for setRegion(Object)

Hi guys, I keep getting the same problem over again anytime i use the getframe i.e. setRegion(walkAnimation.getKeyFrame(stateTime, true));
Getting this long error..
Error:(33, 8) Gradle: error: no suitable method found for setRegion(Object)
method TextureRegion.setRegion(Texture) is not applicable
(argument mismatch; Object cannot be converted to Texture)
method TextureRegion.setRegion(TextureRegion) is not applicable
(argument mismatch; Object cannot be converted to TextureRegion)
Any ideas?

Mario doesn't die when falling in a pit

When falling in a pit, Mario should die.
Also when falling from the ground at the beginning and at the end of the level, Mario should die.

Clearing enemy issue

Hi there
The code has not been updated to your latest revision in the videos. I am trying to find the part where you clear the enemies from the arrays. My code is failing when i kill an enemy. Turtles show up when i fire a ball. and my JVM crashes.

A fatal error has been detected by the Java Runtime Environment:

EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x0000000066bcbd0d, pid=916, tid=0x000000000000307c

JRE version: OpenJDK Runtime Environment (8.0_152-b01) (build 1.8.0_152-release-915-b01)

Java VM: OpenJDK 64-Bit Server VM (25.152-b01 mixed mode windows-amd64 compressed oops)

Problematic frame:

C [gdx-box2d64.dll+0xbd0d]

Failed to write core dump. Minidumps are not enabled by default on client versions of Windows

Please help