Comments (2)
BrentOzar
commented on June 27, 2024
I closed the pull request because it added a confusing parameter. If you're okay with just skipping model, then use the existing @SkipModel parameter. Otherwise, to solve the problem you're discussing here, your original design would be correct:
A sanity check must be included to verify that we can view the objects in the model database. If we can't view the objects Check 29 must be added to the #SkipChecks table
If you don't have the time to do that, I totally understand - just let me know and I can close this issue.
from sql-server-first-responder-kit.
BrentOzar
commented on June 27, 2024
Thanks for the pull request! Looks good, merging into the dev branch, will be in the next release with credit to you in the release notes.
from sql-server-first-responder-kit.
Related Issues (20)
- Stop sp_BlitzQueryStore returning the "rn" column HOT 1
- sp_BlitzIndex - Mode 2 should fail more loudly when BringThePain is needed
- sp_BlitzIndex - Skip missing index details for Modes 1 and 2 HOT 2
- sp_BlitzIndex - The ColumnNamesWithDataTypes common table expression is dog slow sometimes
- CONTRIBUTING.md and README.md don't agree on supported versions HOT 1
- sp_BlitzQueryStore: Let's make the commenting style consistent HOT 1
- sp_BlitzQueryStore: There are lots of user-facing double spaces, missing spaces, typos, and twice-terminated sentences. HOT 1
- sp_BlitzQueryStore: Make the various calls to SERVERPROPERTY less repetitive and capture the current database's compatibility level in a variable HOT 1
- sp_BlitzQueryStore: Replace TOP X with TOP (X) HOT 1
- sp_BlitzQueryStore: Several of the temp tables don't have comments. HOT 1
- sp_BlitzQueryStore: What is this comment trying to say? HOT 4
- sp_Blitz: New security-related checks for SQL Server and Agent running as privileged accounts HOT 2
- sp_BlitzFirst.sql: Incorrect URL for Slow Data File Reads HOT 1
- sp_BlitzQueryStore: The "multiple plans" warning flags up even when you only have one plan. HOT 2
- sp_BlitzFirst: add @ExpertMode = 2 switch to skip sp_BlitzWho
- sp_BlitzFirst: "Garbage Collection in Progress" warning can be triggered by memory-optimized TempDB
- sp_BlitzFirst: add analysis of sys.dm_os_memory_clerks usage HOT 1
- sp_BlitzFirst: add warning about approaching max worker threads
- sp_BlitzFirst: plan cache results show up when they shouldn't
- sp_Blitz_who : transaction_isolation_level wrongly reported HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sql-server-first-responder-kit.