brianbelhumeur/node-express-json-rpc2

A node.js Express middleware to handle JSON-RPC (v2) requests within routes

node-express-json-rpc2's Issues

Support HTTP corresponding error codes

As described here:
http://www.jsonrpc.org/historical/json-rpc-over-http.html#errors
I would love to have responses with HTTP error codes corresponding to the JSON-RPC error codes:
404 - Method not found
400 - Invalid request
500 - any other error

Failed delayed response (async response in callback)

   var fs = require('fs');

    res.rpc('filecontent', function (params, respond) {
        fs.readFile('readme.txt', function(err, data) {
            respond({ result: 'ok:)'});
        });
    });

response is null

jsonp requests on't support post - only get

so there's no guarantee anything is going to be in req.body

the line rpcList = req.body should be changed to
rpcList = req.body || req.query;
that way it handles posts and gets

Hope all is going well.

Documentation is wrong [README file]

it is

app.use( jsonrpc() );

instead of

app.use( express.jsonrpc() );

.... has no method 'jsonrpc'

Hi there,

I am getting an the following error when starting node -

app.use( express.jsonrpc() );
^
TypeError: Object function createApplication() {
var app = connect();
utils.merge(app, proto);
app.request = { proto: req };
app.response = { proto: res };
app.init();
return app;
} has no method 'jsonrpc'

My setup code is as follows -

var express = require('express')
, routes = require('./routes')
, user = require('./routes/user')
, jobs = require('./routes/jobs')
, http = require('http')
, path = require('path')
, jsonrpc = require('node-express-json-rpc2');

var app = express();

// all environments
app.set('port', process.env.PORT || 3000);
app.set('views', __dirname + '/views');
app.set('view engine', 'jade');
app.use( express.jsonrpc() );
app.use(express.favicon());
app.use(express.logger('dev'));
app.use(express.bodyParser());
app.use(express.methodOverride());
app.use(app.router);
app.use(express.static(path.join(__dirname, 'public')));

Is this a bug or have I messed up?!

Thanks,
Sean

edit:

I added express.jsonrpc = jsonrpc and the error is no more however all rpc calls come back with method not found errors.