briangilbert/docksal-core-sprint

docksal-core-sprint's Issues

Drupal Console not installed

I'm getting the following error on fin init:

[ERROR] Drupal Console is not installed at:                                                 
         /var/www/docroot                                                                    
   You must execute the following composer commands:
 composer require drupal/console:~1.0 --prefer-dist --optimize-autoloader

I can manually do that, but then afterwards it's not clear if I need to run fin init again? From my experience doing so twice seems to cause everything to hang. Would be nice if this just worked without having to worry about that.

[meta] Mentor Feedback

This is a thread for mentor feedback.

Maybe use pip to install docker-compose?

I've been having success with the following pattern for docker-compose:

A Makefile with

all:
        make -s install

clean:
        rm -fr env

install:
        test -d env || pyvenv env
        if [ ! -d env/lib/python3*/site-packages/bs4 ]; then \
                . env/bin/activate && pip install -r requirements.txt; \
        fi

and a requirements.txt with

docker-compose==1.12.0

Then I can do . env/bin/activate and run fin init from there. If I'm not using that Python env anymore I run env/bin/deactivate.