brianlow/keras_diagram

Keras models as ASCII diagrams

keras_diagram's Issues

maximum recursion depth exceeded while processing keras.applications.resnet50

Used keras-diagram 1.0.5 pulled from pip.

Loaded resnet50 model from keras. Then, used keras_diagram.ascii(model) results in maximum recursion depth exceeded.

Failure with shared embedding layer

I'm using a shared embedding layer between multiple lengths of sequence inputs and get the following error:

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in ascii(model)
    167 
    168 def ascii(model):
--> 169     node = Node(model.layers[-1])
    170     return node.render()
    171 

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in __init__(self, layer)
     11         self.layer = layer
     12         self.text = "%20s %-20s" %  (self._name(), layer.output_shape)
---> 13         self.children = self._calculate_children()
     14         self.node_width = len(self.text)
     15         self.family_width = self._calculate_family_width()

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in _calculate_children(self)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in <listcomp>(.0)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in __init__(self, layer)
     11         self.layer = layer
     12         self.text = "%20s %-20s" %  (self._name(), layer.output_shape)
---> 13         self.children = self._calculate_children()
     14         self.node_width = len(self.text)
     15         self.family_width = self._calculate_family_width()

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in _calculate_children(self)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in <listcomp>(.0)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in __init__(self, layer)
     11         self.layer = layer
     12         self.text = "%20s %-20s" %  (self._name(), layer.output_shape)
---> 13         self.children = self._calculate_children()
     14         self.node_width = len(self.text)
     15         self.family_width = self._calculate_family_width()

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in _calculate_children(self)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in <listcomp>(.0)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in __init__(self, layer)
     11         self.layer = layer
     12         self.text = "%20s %-20s" %  (self._name(), layer.output_shape)
---> 13         self.children = self._calculate_children()
     14         self.node_width = len(self.text)
     15         self.family_width = self._calculate_family_width()

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in _calculate_children(self)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in <listcomp>(.0)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in __init__(self, layer)
     11         self.layer = layer
     12         self.text = "%20s %-20s" %  (self._name(), layer.output_shape)
---> 13         self.children = self._calculate_children()
     14         self.node_width = len(self.text)
     15         self.family_width = self._calculate_family_width()

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in _calculate_children(self)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in <listcomp>(.0)
     25         layers = list(_flatten([node.inbound_layers for node in self.layer.inbound_nodes]))
     26         layers = [l.layers[-1] if issubclass(type(l), Model) else l for l in layers]
---> 27         return [Node(l) for l in layers]
     28 
     29     def _calculate_family_width(self):

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras_diagram/diagram.py in __init__(self, layer)
     10     def __init__(self, layer):
     11         self.layer = layer
---> 12         self.text = "%20s %-20s" %  (self._name(), layer.output_shape)
     13         self.children = self._calculate_children()
     14         self.node_width = len(self.text)

/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras/engine/topology.py in output_shape(self)
    827                             'the notion of "output shape" is ' +
    828                             'ill-defined for the layer. ' +
--> 829                             'Use `get_output_shape_at(node_index)` instead.')
    830 
    831     def set_weights(self, weights):

Exception: The layer "amino_acid_embedding has multiple inbound nodes, with different output shapes. Hence the notion of "output shape" is ill-defined for the layer. Use `get_output_shape_at(node_index)` instead.

AttributeError: 'function' object has no attribute 'func_name'

Hi, while executing the babi_memnn.py file as in https://pypi.python.org/pypi/keras-diagram (on my Windows 10 system, python 3.5 and keras installed by pip):

I get the error:

Compiling...
Traceback (most recent call last):
File "k.py", line 198, in
print(ascii(answer))
File "C:\Program Files\Anaconda2\envs\py35\lib\site-packages\keras_diagram\diagram.py", line 169, in ascii
node = Node(model.layers[-1])
File "C:\Program Files\Anaconda2\envs\py35\lib\site-packages\keras_diagram\diagram.py", line 12, in init
self.text = "%20s %-20s" % (self._name(), layer.output_shape)
File "C:\Program Files\Anaconda2\envs\py35\lib\site-packages\keras_diagram\diagram.py", line 20, in _name
return self.layer.activation.func_name.title()
AttributeError: 'function' object has no attribute 'func_name'

@brianlow could you take a look? Thanks.

TypeError with concatenate layer

model_input = Input(
              shape=(3,),
              name='Input')

hidden = Dense(
         units=7,
         activation=K.relu,
         name="Hidden")(model_input)

means = Dense(
        units=7, 
        name='Means')(hidden)

variances = Dense(
            units=7,  
            activation=K.exp, # enforce positivity
            name='Covariances')(hidden)

posterior = concatenate(
   [means, variances],
   name='Posterior_Params')

model = Model(
       inputs=model_input,
       outputs=[posterior])

print(ascii(model))

throws exception:

> Traceback (most recent call last):
  File "test_ascii_model.py", line 56, in <module>
    print(ascii_model(model))
  File "[redacted]/python3.6/site-packages/keras_diagram/diagram.py", line 170, in ascii
    return node.render()
  File "[redacted]/python3.6/site-packages/keras_diagram/diagram.py", line 71, in render
    return str(self.canvas())
  File "[redacted]/python3.6/site-packages/keras_diagram/diagram.py", line 61, in canvas
    a = Arrows(canvas.width())
  File "[redacted]/python3.6/site-packages/keras_diagram/diagram.py", line 135, in __init__
    self.line1 = create_string_buffer(' ' * width)
  File "/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/ctypes/__init__.py", line 63, in create_string_buffer
    raise TypeError(init)
TypeError:                                         

The same model with either means or variances as output prints out correctly.

Using python 3.6, Keras 2.0.8, tensorflow 1.1.0, on OSX.

Keras variable name change

In Keras 2.1.4 (or possibly earlier) they changed layer.inbound_nodes to layer._inbound_nodes. The underscore change needs to made in 1 place in keras_diagram

Customizable layer text

Accept a format string or a function to convert a layer into a text string