brightbox/brightbox-deployment

Brightbox Capistrano Rails deployment recipes

brightbox-deployment's Issues

should allow disabling packages:install

seems to run apt-get update even when no dependencies are defined. be handy to be able to disable it so you never need sudo (or maybe fix whatever causes it run!)

monit binary moved in Ubuntu precise

for some reason we're trying to use /usr/sbin/monit but the precise package has moved it to /usr/bin/monit

we should probably not hardcode the full path and just use a normal PATH lookup.

License missing from gemspec

Some companies will only use gems with a certain license.
The canonical and easy way to check is via the gemspec
via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

There is even a License Finder to help companies ensure all gems they use
meet their licensing needs. This tool depends on license information being available in the gemspec.
Including a license in your gemspec is a good practice, in any case.

If you need help choosing a license, github has created a license picker tool

How did I find you?

I'm using a script to collect stats on gems, originally looking for download data, but decided to collect licenses too,
and make issues for missing ones as a public service :)
https://gist.github.com/bf4/5952053#file-license_issue-rb-L13 So far it's going pretty well.
I've written a blog post about it

License missing from gemspec

Some companies will only use gems with a certain license.
The canonical and easy way to check is via the gemspec
via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

There is even a License Finder to help companies ensure all gems they use
meet their licensing needs. This tool depends on license information being available in the gemspec.
Including a license in your gemspec is a good practice, in any case.

If you need help choosing a license, github has created a license picker tool

How did I find you?

I'm using a script to collect stats on gems, originally looking for download data, but decided to collect licenses too,
and make issues for missing ones as a public service :)
https://gist.github.com/bf4/5952053#file-license_issue-rb-L13 So far it's going pretty well.
I've written a blog post about it

Hard restart strategy

Hey,

I'm wondering why the passenger hard_restart task does both a soft and a hard restart i.e. touching of tmp/restart.txt and also then killing the ApplicationSpawner and the children. Is there a specific reason to not just do the latter?

Thanks.

Installing gems with sudo disregarding settings

We were trying to deploy an application built with Rails 2.3.18, which does not use bundler, and uses rvm in the server and we came across an issue related with the brightbox gem, namely with this line: https://github.com/brightbox/brightbox-deployment/blob/master/lib/brightbox/recipes/gems.rb#L33

def install_gem(gem, version, options = nil)
  source_arg = options && options[:source] ? "--source #{options[:source]}" : ""
  run %Q{sh -c "
   gem spec #{gem} --version '#{version}' 2>/dev/null|egrep -q '^name:' ||
   sudo -p '#{sudo_prompt}' gem install --no-ri --no-rdoc --version '#{version}' #{source_arg} #{gem}"
  }
end

Here gems are installed using sudo regardless of the settings that we define in our deploy.rb file.

I would propose changing it to:

def install_gem(gem, version, options = nil)
  source_arg = options && options[:source] ? "--source #{options[:source]}" : ""
  run %Q{sh -c "
    gem spec #{gem} --version '#{version}' 2>/dev/null|egrep -q '^name:' ||
    #{if use_sudo then "sudo -p '#{sudo_prompt}'" end} gem install --no-ri --no-rdoc --version '#{version}' #{source_arg} #{gem}"
  }
end

Or something along those lines.

Cheers and good work with the Brightbox gem. :)