Giter Site home page Giter Site logo

Comments (4)

alistairsykes avatar alistairsykes commented on August 16, 2024 1

Sorry the language does make it sound scary, but I just inherited that from the camera api's. It should be safe to do so. If you see any issues with that do report them.

Thanks for reporting this one. It's just not a case I'd really thought about.

I will try to work on a fix for this as soon as I can.

from kbarcode.

alistairsykes avatar alistairsykes commented on August 16, 2024

Super interesting use case. I'd never considered wanting to pause the preview.

I think given the nature of library, I'm not sure that having a pausePreview() would really fit, and I think to achieve this release and start is the right approach. However I do think that releasing and starting shouldn't re-yield the previous barcodes.

I think the potential solution here is to clear the value from the LiveData whenever release() is called. I'm not sure yet if this should happen in BarcodeScanner or BarcodeProcessorSingle. That should mean that you could continue with your approach, do you think that would work for you @maartenvang ?

from kbarcode.

maartenvang avatar maartenvang commented on August 16, 2024

Hi @alistairsykes , thanks for the swift reply.
I wasn't sure whether to report a bug for the re-yielding of the previous barcodes, or to add a feature request to pause / restart the preview. I went for the first one, but perhaps a bug should have been better.

I think that clearing the scanned barcodes in release() already fixes the issues I'm having, whilst not being a breaking change. Only, calling release() to pause the preview sounds scary when you still intend to use the same barcodeView, but it seems safe to do so.

from kbarcode.

alistairsykes avatar alistairsykes commented on August 16, 2024

Released https://github.com/brightec/KBarcode/releases/tag/v1.1.0

from kbarcode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.