Comments (4)
Sorry the language does make it sound scary, but I just inherited that from the camera api's. It should be safe to do so. If you see any issues with that do report them.
Thanks for reporting this one. It's just not a case I'd really thought about.
I will try to work on a fix for this as soon as I can.
from kbarcode.
Super interesting use case. I'd never considered wanting to pause the preview.
I think given the nature of library, I'm not sure that having a pausePreview()
would really fit, and I think to achieve this release and start is the right approach. However I do think that releasing and starting shouldn't re-yield the previous barcodes.
I think the potential solution here is to clear the value from the LiveData whenever release()
is called. I'm not sure yet if this should happen in BarcodeScanner
or BarcodeProcessorSingle
. That should mean that you could continue with your approach, do you think that would work for you @maartenvang ?
from kbarcode.
Hi @alistairsykes , thanks for the swift reply.
I wasn't sure whether to report a bug for the re-yielding of the previous barcodes, or to add a feature request to pause / restart the preview. I went for the first one, but perhaps a bug should have been better.
I think that clearing the scanned barcodes in release()
already fixes the issues I'm having, whilst not being a breaking change. Only, calling release()
to pause the preview sounds scary when you still intend to use the same barcodeView, but it seems safe to do so.
from kbarcode.
Released https://github.com/brightec/KBarcode/releases/tag/v1.1.0
from kbarcode.
Related Issues (20)
- [FEATURE] Click to focus in barcode view HOT 6
- Surface had no valid native window. on barcodeView.start() HOT 7
- [BUG] Samsung Galaxy S9 HOT 2
- [FEATURE] Ui test HOT 6
- [QUESTION] - minSDK HOT 1
- [BUG] Screen Lag every second HOT 9
- RTFM: Does this lib support QrCode? HOT 1
- Dim light
- The image quality is fairly poor. HOT 1
- [FEATURE] Toggle flash on/off HOT 2
- [BUG] Crash on VisionImageProcessorSingleBase$startDetection$2.onComplete() HOT 2
- [FEATURE] Black screen when Camera permission denied. HOT 1
- How to capture or retreive the Image frame being scanned HOT 3
- [BUG] Library doesn't work at all HOT 2
- [FEATURE] FirebaseVisionBarcode is deprecated, migrate to ML Kit SDK HOT 2
- [BUG] Black bar on the right HOT 1
- Crash on back HOT 2
- [FEATURE] Add Data Safety information HOT 1
- [BUG] Detection stops working when toggling flash HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kbarcode.