brightid/sponsorship-subscriptions-smartcontracts

BrightID Sponsorships and Subscriptions smart contracts

www.brightid.org

Unique Human Identity

BrightID allows you to prove to applications that you're only using one account.

• No personal data or biometrics are used for verification.
• Verified by a trusted group of close personal contacts plus a decentralized graph database.
• A lost or compromised ID can be replaced by reconnecting with a few close personal contacts.

Decentralized & Nonintrusive

The network consists of volunteers running nodes. Nodes host the social graph used for verification, but there's no personal information stored there.

Mobile App

ID creation and connections to people and apps are managed through the BrightID mobile app.

Contribute

Contributions to translations are welcome through weblate.

• Project board
• All BrightID repos
• More information on contributing may be found in our Github Wiki.
• Apply to our keybase to talk with other contributors.

Integrating BrightID in your Project

• API spec and guides for developers integrating BrightID.
• See also the BrightID Node repo.

sponsorship-subscriptions-smartcontracts's Issues

Make subscription batches publicly visible

Could we make this mapping public https://github.com/BrightID/Sponsorship-Subscriptions-SmartContracts/blob/master/contracts/Subscriptions.sol#L26 ?

That way a user (or anyone) could see when a subscription batch was purchased and how many subscriptions are in it.

See Subscriptions Balances in the spec.

Lock compiler version

What do you think about locking the compiler version as recommended here?

SubscriptionsActivated Event

If we make Subscriptions transferable, we should add an event like this:

event SubscriptionsActivated(address account, uint256 amount);

See also #3

Emit an event when a context is assigned

Should have context name, number of sponsorships that were assigned, and address that assigned them.

Can't filter SponsorshipsAssigned events

To be able to find out how many sponsorships you personally have assigned to a context, you have to download all SponsorshipAssigned events--including those from all people and for all contexts (not just the relevant ones)--because we didn't add an indexed keyword after the contextName and account parameters to the SponsorshipAssigned event.

Soon there will be too many SponsorshipAssigned events, and there this will become too large to download.

Checking the number of sponsorships assigned to a context by all accounts can still be done using the totalContextBalance() function.

Subscriptions shouldn't inherit from ERC20Capped

Let's enforce the cap in the SubscriptionsMinter only.

Unless BMAIN DAO gives up all minter roles, they can always bypass the cap by simply creating a new kind of Subscriptions with a different cap.

We don't want to give up all minter roles (because we want to be able to upgrade or replace minters), so having an overall cap is meaningless.

The cap is for this sale only.

This also allows us to maintain only one cap variable instead of trying to have two that are in sync.

This also allows us to not care about the overall supply going down when a subscription is activated (burned) if we choose to make subscriptions transferable.

Pass contract types instead of address type

What about this recommendation for FinanceManager.sol?

We are passing address types and then converting them into Finance or ERC20 types. Consensys recommends to pass the contract types instead.

Add index to IdSponsorshipsAssigned and SponsorshipsAssigned events

The address and contextName aren't indexed here https://github.com/BrightID/Sponsorship-Subscriptions-SmartContracts/blob/master/idchain/IdSponsorships.sol#L31 . This will make filtering difficult when there are many sponsorships being assigned in the future.

Can't filter SubscriptionsActivated events

To be able to find out how many "active" subscriptions you have, you have to download everyone's SubscriptionsActivated events (not just yours) because we didn't add an indexed keyword after the account parameter to the SubscriptionsActivated event.

If there are many SubscriptionsActivated events, this may become too large to download.