brokenseal/eunomia

Data Context Interaction library aiming Javascript

eunomia's Issues

A few example fixes

Hello! Nice project, great to see some DCI initiatives. A few comments about the example:

In the context code, actors.choosesFood should be actors.customer.choosesFood, right? And I don't see a menu Role, so actors.menu seems incorrect, but then there's a menu argument in roles.customer.choosesFood, which suggests that the menu isn't a Role at all in the Context (otherwise it doesn't need to be passed around as an argument).

I also think there's a semantic issue with actors, why not call them argument what they are inside the Context, roles, or even context (depends on the passed object of course)? Actors aren't a part of the DCI terminology, and a Role in DCI is just an identifier, so the Eunomia definition doesn't match the DCI definition exactly, which could be confusing.

By creating a separate role object as in the example, the code seems to suggest that Roles can be reused between Contexts, which they shouldn't, but a simple note of that should be enough. (I prefer to put them in the same object directly, look at https://github.com/ciscoheat/haxedci-example for an example)

Lastly, I don't see any interactions between Roles. The example is simplified of course, but to a beginner it looks like the interactions should be orchestrated by the Context. Rather the RoleMethods should call each other, to create a distributed algorithm instead of a monolithic, all-knowing Context. The Context just kicks off an interaction (from takeOrder and serveFood), not much more.

Except for that the structure looks good, and I assume that the Roles won't have a wrapper to create identity issues, so I'll be following this with interest!

Source Map as an external file for the Browser

It's nice that the node version includes the source map. It would be nice to have that for the minified browser version (just as a separate file).