broxus/ever-wallet-api

Self-hosted wallet management service

ever-wallet-api's Issues

No sender in TIP3 callbacks

Example

{
  "id": "ad5e0174-4eeb-4b64-aae8-6f3966ec51b5",
  "transactionId": "6c354b16-b28c-4135-82b4-93081f8e9b46",
  "transactionHash": "d9994ad2ede3b81befb5f27f103569a7a6041b049259788bd55fb9f0ac2e7669",
  "messageHash": "598b70d6cf4baed2525aba5b4c9bf5d3c35b090801fdca9149b95b69179ea4cc",
  "ownerMessageHash": null,
  "account": {
    "workchainId": 0,
    "hex": "e310334bb9c391762448a046f509fd14f288a7bad178f7d023ade10792cf236b",
    "base64url": "EQDjEDNLucORdiRIoEb1Cf0U8oinutF499AjreEHks8jaxPq"
  },
  "sender": null,
  "balanceChange": "10000000000000000",
  "rootAddress": "0:34eefc8c8fb2b1e8da6fd6c86c1d5bcee1893bb81d34b3a085e301f2fba8d59c",
  "transactionDirection": "Receive",
  "transactionStatus": "Done",
  "eventStatus": "New",
  "multisigTransactionId": null,
  "createdAt": 1718657835423,
  "updatedAt": 1718657835423
}

There is sender though in transaction
https://everscan.io/transactions/d9994ad2ede3b81befb5f27f103569a7a6041b049259788bd55fb9f0ac2e7669/token-operations

Mark event does not work

Service keeps sending the same events even after invocation events_mark_post and receiving response: 'status': 'Ok'.

Add endpoint for token whitelist

Currently, no information about the actual whitelist and tracked tokens is provided for dependent service.

Transactions API documentation improvement

The endpoint

/ton/v3/transactions/id/854c419dc34727bcb403f89b46a98045f1c29caa7de0e88063e4d6f7f5ce860c

It is highly confusing because what is meant is internal transaction ID.

"Create transaction" payload documentation

The documentation misses the exact specification of JSON payload serialization and exists only implicitly in wallet.sh.

The important moment here of course, the amount of empty spaces or indent parameter.

Readme specifies more fields than exist in wallet.sh. This is another strange moment since these fields have no explanation.

Not generated by the service (external) address leads to server error

Log output.

Dec 13 21:20:44 evernode ton-wallet-api[548446]: INFO ton_wallet_api::api = started GET /ton/v3/address/0:82d6884271fab6516973024db8247c807f56085c99526d965d4bae695885f969
Dec 13 21:20:44 evernode ton-wallet-api[548446]: INFO sqlx::query = SELECT id, service_id as …; rows affected: 0, rows returned: 0, elapsed: 373.698µs
Dec 13 21:20:44 evernode ton-wallet-api[548446]: SELECT
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   id,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   service_id as "service_id: _",
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   workchain_id,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   hex,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   base64url,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   public_key,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   private_key,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   account_type as "account_type: _",
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   custodians,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   confirmations,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   custodians_public_keys,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   balance,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   created_at,
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   updated_at
Dec 13 21:20:44 evernode ton-wallet-api[548446]: FROM
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   address
Dec 13 21:20:44 evernode ton-wallet-api[548446]: WHERE
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   service_id = $1
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   AND workchain_id = $2
Dec 13 21:20:44 evernode ton-wallet-api[548446]:   AND hex = $3
Dec 13 21:20:44 evernode ton-wallet-api[548446]:  
Dec 13 21:20:44 evernode ton-wallet-api[548446]: ERROR ton_wallet_api::api::error = Generic error: no rows returned by a query that expected to return at least one row

Callback documentation & event status

1. Documentation in README.md does not correspond to actual endpoints in Swagger
2. Service returns {'error_message': None, 'status': 'Ok'} on the submitted event, but it (actually they) keeps appearing in the list of events

If /mark should somehow let the service know that the event was processed, then this is a bug. If events should be provided on every /events call then disregard this report besides documentation issues.