Giter Site home page Giter Site logo

medusa-crawler's People

Contributors

bernd avatar brownbeagle avatar brutuscat avatar chriskite avatar donv avatar lpradovera avatar mislav avatar mothonmars avatar nehhen avatar paresharma avatar rb2k avatar skojin avatar spk avatar tilsammans avatar zirconcode avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

medusa-crawler's Issues

skip_links_like does not match patterns in query strings

Steps:
Attempt to skip patterns in a query string during a crawl:

Medusa.crawl(url, depth_limit: 1, discard_page_bodies: true) do |medusa|
  medusa.skip_links_like(/sort=desc/)
  medusa.on_every_page do |page|
    puts page.url if /sort=desc/.match(page.url.to_s)
  end
end

Expected Results:

  • no URLs are crawled that include the pattern in the query string

Actual Results:
URLs are crawled that include the pattern in the query string:

https://www.va.gov/vapubs/Search_action.cfm?formno=&tkey=&dType=1&SortBy=pub_num&sort=desc&oid=0
https://www.va.gov/vapubs/Search_action.cfm?formno=&tkey=&dType=1&SortBy=issue&sort=desc&oid=0
https://www.va.gov/vapubs/Search_action.cfm?formno=&tkey=&dType=1&SortBy=title&sort=desc&oid=0
https://www.va.gov/vapubs/Search_action.cfm?formno=&tkey=&dType=1&SortBy=rpch&sort=desc&oid=0

This seems like an oversight, rather than the desired behavior, and I can put in a PR to fix this. If this is the desired behavior, there should be another mechanism to skip links based on query string patterns/keys/values, etc.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.