brycesenz/simple_params

A simple class for specifying parameters for an API, service object, etc.

simple_params's Issues

Exceptions and deprecations with Rails 6.1

Failure/Error: message = normalize_message(attribute, message, options)
      
      NoMethodError:
        undefined method `normalize_message' for #<SimpleParams::Errors:0x000055becb5cb888>
        Did you mean?  normalize_arguments

After solving the above there are subsequent issues. I attempted to make the changes myself, but quickly got in over my head.

simple_action and simple_params have been really useful for us. Thanks for your work on them.

Fix security issues

https://github.com/brycesenz/simple_params/network/alerts

Add Rails form helper/compatibility methods

In order to SimpleParams objects to work seamless with Rails forms, they need to support a few different methods:

• Params have to respond to "persisted?"
• For nested params, e.g., "dogs", then the params should also be able to set those params through "dogs_attributes"
  • Again, for "dogs", params should respond to "build_dog".

Optional nested arrays aren't working correctly.

When a set of params has an optional nested array, it still returns errors if the optional array is not initialized. I need to add a spec to verify the correct functionality and fix this issue.

NestedParams and Nested hashes should be their own classes

The Params class is becoming incredibly bloasted and complex. It should be split into sub classes, and ideally separated into other modules as well.

Error in Rails apps due to a lack of ActiveModel name

Here is an example backtrace:

ArgumentError:
Class name cannot be blank. You need to supply a name argument when anonymous class given
# /Users/user/.rvm/gems/ruby-2.2.0@app/gems/activemodel-4.2.0/lib/active_model/naming.rb:148:in initialize' # /Users/user/.rvm/gems/ruby-2.2.0@app/gems/activemodel-4.2.0/lib/active_model/naming.rb:239:innew'
# /Users/user/.rvm/gems/ruby-2.2.0@app/gems/activemodel-4.2.0/lib/active_model/naming.rb:239:in model_name' # /Users/user/.rvm/gems/ruby-2.2.0@app/gems/activemodel-4.2.0/lib/active_model/errors.rb:418:inblock in generate_message'

Add compatibility for Rails/ActiveModel >= 5.0

ActiveModel has undergone some significant changes, and this gem no longer plays well with Rails 5

Params with default provided should have ApiPieDocumentation of "required: false"

Currently, ApiPieDocumentation will consider something with a default to be required. That should not be true.

Params should respond to ActiveModel style before_* and after_* validation hooks

One should be able to add before and after validation hooks, just like you can on ActiveModel objects.

Optional params aren't optional when validating inclusion

The following param definition should be valid even when the param is nil -

param :age, optional: true, validations { inclusion: { in: ["a", "b"] } }

But it isn't. I believe that the solution is going to be to add an "allow_nil" tag to the validations hash when optional is true. E.g.

validates :age, :inclusion => { :in => ['a', 'b'] }, :allow_nil => true

Params should respond to reflect_on_association

This method, and the klass method (http://apidock.com/rails/ActiveRecord/Reflection/AssociationReflection/klass) are ActiveRecord methods that are used in building nested forms.

Our Params class should support these methods in order to be used in the same forms.