bsgworld/bsg-nodejs

The open source Node.js client for BSG's REST API. SMS, Viber, HLR services

bsg-nodejs's Issues

Wrong github link

Npm package points to: https://github.com/bsg/bsg-nodejs as homepage of the repository.
Can you please fix it to https://github.com/bsgworld/bsg-nodejs

how can i send bulk sms

bsg.createSMS(
{
destination: "phone",
originator:"alpha name",
body:"message text",
msisdn:"380972000000",
reference:"ext_id_16",
validity:"1",
tariff:"0"
}
)

will the receivers number be in an array , example
msisdn:["380972000000","2737278222']

If put property "callback_url" in method createSMS it crashes.

Wrong check property 'callback_url' in file police.js, method 'createSMS'
File police.js, method createSMS, line 284: '!patterns.url.match( fields.callback_url ) ){' , need to replace with '!patterns.url.test( fields.callback_url ) ){', because 'patterns.url' is RegExp and not contain method 'match', need to replace it with method 'test'. Or some other fix...
Error description:
TypeError: patterns.url.match is not a function
at Object.createSMS (/path/to/project/node_modules/bsg-nodejs/lib/police.js:284:19)
at /path/to/project/node_modules/bsg-nodejs/lib/bsg.js:154:32
at Array.forEach ()
at Object.createSMS (/path/to/project/node_modules/bsg-nodejs/lib/bsg.js:152:11)
...

Service crashes when there is no internet connection

Need to fix error handling in the "remoteCall" method(file: bsg-nodejs/lib/bsg.js). Mismatch error variable name in "request" callback function(file:52). And mismatch error variable name in subsequent try/catch statement(file:58).

Current error callstack:
/path/to/dir/node_modules/bsg-nodejs/lib/bsg.js:52
reject( BSG server rejected request on HTTP level: ${e} );
^

ReferenceError: e is not defined
at Request._callback (/path/to/dir/node_modules/bsg-nodejs/lib/bsg.js:52:63)
at self.callback (/path/to/dir/node_modules/bsg-nodejs/node_modules/request/request.js:186:22)
at Request.emit (events.js:315:20)
at Request.onRequestError (/path/to/dir/node_modules/bsg-nodejs/node_modules/request/request.js:845:8)
at ClientRequest.emit (events.js:315:20)
at TLSSocket.socketErrorListener (_http_client.js:467:9)
at TLSSocket.emit (events.js:315:20)
at emitErrorNT (internal/streams/destroy.js:100:8)
at emitErrorCloseNT (internal/streams/destroy.js:68:3)
at processTicksAndRejections (internal/process/task_queues.js:84:21)