Giter Site home page Giter Site logo

civ6-capslock's People

Contributors

bszonye avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

civ6-capslock's Issues

New terrain check causes type error

hexal reports:

After the last update this is no longer compatible with Got Lakes Map Script. City states and tribal villages will not spawn.

I was able to reproduce, with this error:

Runtime Error: C:\Users\bradd\Documents\My Games\Sid Meier's Civilization VI\Mods\capslock\AssignStartingPlots.lua:567: operator - is not supported for number - boolean
stack traceback:
        C:\Users\bradd\Documents\My Games\Sid Meier's Civilization VI\Mods\capslock\AssignStartingPlots.lua:567: in function 'AssignStartingPlots:__SetStartMinor'
        C:\Program Files (x86)\Steam\steamapps\workshop\content\289070\916614621\GotLakes.lua:13424: in function 'AssignStartingPlots:__InitStartingData'
        C:\Users\bradd\Documents\My Games\Sid Meier's Civilization VI\Mods\capslock\AssignStartingPlots.lua:79: in function 'AssignStartingPlots.Create'
        C:\Program Files (x86)\Steam\steamapps\workshop\content\289070\916614621\GotLakes.lua:16647: in function 'DetermineStartingPlots'
        C:\Program Files (x86)\Steam\steamapps\workshop\content\289070\916614621\GotLakes.lua:16676: in function 'GenerateMap'
    [C]: in function '(anonymous)'

It looks like Got Lakes is overriding some of the functions in the AssignStartingPlots object, and failing because the interface is no longer consistent (number score instead of boolean check).

Fix weights for polar starts & adjacent terrain

The self:__GetValidAdjacent check is only given +1 weight. That function checks both for polar starts and for bad adjacent terrain. The low weight means that civs can still end up in polar snow, especially if the major civ buffer produces a high penalty score.

YnAMP compatibility

The YnAMP mod also overrides AssignStartingPlots.lua with LoadOrder=2. Therefore, Caps Lock will break their True Start Location scripting at least, and possibly more.

Some possible resolutions:

  • Mark YnAMP as an incompatible mod to avoid broken combinations.
  • Reduce the Caps Lock LoadOrder from 12,000 to 1 so that YnAMP takes precedence.
  • Contribute the Caps Lock improvements to YnAMP and coordinate LoadOrder.

The first two resolutions would also enable a “Caps Lock + YnAMP” compatibility shim that combines the two mods, but I would prefer to avoid the parallel coding that would entail.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.