[BUG] Massive size mismatch for minified code

[thoughtspile]

[BUG] Massive size mismatch for minified code

[thoughtspile]

Actually, sourcemap: true correctly computes renderedLength, but later it's dismissed in ModuleLengths.

This computation can be better adjusted for unicode by this change in getBytesPerFileUsingSourceMap:

- modules[id].renderedLength += 1;
+ modules[id].renderedLength +=  Buffer.byteLength(code[i], "utf-8");`

Ran additional tests on date-fns/locale (a lot of unicode), here are the results:

1. Actual bundle size: 597kB
2. Reported: 990kB (166% actual), regardless of sourcemap option.
3. Reported using rollup's renderedLength and sourcemap: false: 915kB (153% actual)
4. Reported using renderedLength from current sourcemap: true: 521kB (87% actual)
5. Reported using renderedLength with unicode-adjusted sourcemap: 597kB (matches actual)

How would you feel about using renderedLength when sourcemap option is enabled, and adding unicode adjustment I propose?

[btd]

Hi. First of all Thanks for every detailed issue.
Yes reportered size always different from actual one. Closest you can get to reality with sourcemap option set to true.
I should say i never tried to use non ascii chracters.
It would be nice if you will make PR and i will take a look. Otherwise no ETA.
Also i am curious if we should use codePointAt or anything that correctly traverse code points. Random index could point in the middle of surrogate pair

[btd]

I have published 5.9.2. Take a look pls if it improves size reporting with sourcemap.

[r-thomson]

I have published 5.9.2. Take a look pls if it improves size reporting with sourcemap.

Heads up, 5.9.2 seems to be missing from the changelog

[jasonaden]

I have published 5.9.2. Take a look pls if it improves size reporting with sourcemap.

Heads up, 5.9.2 seems to be missing from the changelog

I think it was supposed to say 5.9.1 since that was published 4 days ago and sounds like it matches this issue.

[r-thomson]

Heads up, 5.9.2 seems to be missing from the changelog

I think it was supposed to say 5.9.1 since that was published 4 days ago and sounds like it matches this issue.

Except there was a 5.9.2 published

[btd]

The difference between 5.9.2 and 5.9.1 is that i dropped 14.x from test matrix