btwael/superstring.py

A fast and memory-optimized string library for heavy-text manipulation in Python

superstring.py's Issues

Add the performance test to the repo

Can you show the code that produced the hard coded numbers in the jupyter notebook?

Feature request: replace

>>> "hi".replace("h", "H")
Hi

Would be neat if it could take a dict so this worked:

>>> "hi".replace({"h": "i", "i": "h"})
ih

Or a regex (see pandas.Series.str for inspiration?):

"hi".replace("h|i", "NYAN")
NYANNYAN

pep-8

Cool library but please implement stuff respecting pep-8. Methods named like characterAt()makes every Python developer sick.

Implement in Cython?

Your library seems like it could take advantage of Cython for greater speedups (but no increase in mem-efficiency).

See https://cython.org/

.length() is not working.

There are several problems with length calculation:

• line8 in SuperStringBase: self.length is a function (change it to .length())
• line13 in SuperStringBase: self.length is a function (change it to .length())
• line154 in SuperStringLower: infinite recursion (change it to self._base.length())
• line167 in SuperStringLower: infinite recursion (change it to self._base.length())