bucharest-gold/fidelity

THIS REPO IS NO LONGER MAINTAINED: A fast and simple Promise/A+ implementation

fidelity's Issues

Update this repository to be more in line with current practices

Same as:
bucharest-gold/automatic-pancake#3

Build error on Windows 10

Related with v8-profiler

First, need python 2.7x installed, otherwise:

$ npm it
npm WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha1-Yi4y6CSItJJ5EUpPns9F581rulU= integrity checksum failed when using sha1: wanted sha1-Yi4y6CSItJJ5EUpPns9F581rulU= but got sha512-q4spe4KTfsAS1SUHLO0wz8Qiyf1+vMIAgpRYioFYDMNqKfHQbg+AVDH3i4fvpl71/P1L0dBl+fQi+P37UYf0ew==. (6052 bytes)
npm WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.

> @risingstack/[email protected] preinstall C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
> node -e 'process.exit(0)'


> [email protected] install C:\Users\hf\Desktop\dev\fidelity\node_modules\fmerge
> node install.js

`fmerge.min.js` created

> @risingstack/[email protected] install C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://oss.risingstack.com/repo/v1/@risingstack/profiler/dist/v5.7.11/node-v57-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/[email protected] and [email protected] (node-v57 ABI) (falling back to source compile with node-gyp)

C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" clean )  else (node "" clean )

C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" configure --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64 )  else (node "" configure --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64 )
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable "C:\Users\hf\AppData\Local\Programs\Python\Python36-32\python.EXE", you can set the PYTHON env variable.
gyp ERR! stack     at PythonFinder.failNoPython (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:483:19)
gyp ERR! stack     at PythonFinder.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:508:16)
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\polyfills.js:284:29
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:152:21)
gyp ERR! System Windows_NT 10.0.16299
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "configure" "--fallback-to-build" "--module=C:\\Users\\hf\\Desktop\\dev\\fidelity\\node_modules\\@risingstack\\v8-profiler\\build\\@risingstack\\profiler\\v5.7.11\\node-v57-win32-x64\\profiler.node" "--module_name=profiler" "--module_path=C:\\Users\\hf\\Desktop\\dev\\fidelity\\node_modules\\@risingstack\\v8-profiler\\build\\@risingstack\\profiler\\v5.7.11\\node-v57-win32-x64"
gyp ERR! cwd C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
gyp ERR! node -v v8.9.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp.cmd configure --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\node-pre-gyp\lib\util\compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:126:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:925:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
node-pre-gyp ERR! System Windows_NT 10.0.16299
node-pre-gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\hf\\Desktop\\dev\\fidelity\\node_modules\\@risingstack\\node-pre-gyp\\bin\\node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
node-pre-gyp ERR! node -v v8.9.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.35
node-pre-gyp ERR! not ok
Failed to execute 'node-gyp.cmd configure --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64' (1)
npm WARN [email protected] requires a peer of ajv@^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @risingstack/[email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @risingstack/[email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\hf\AppData\Roaming\npm-cache\_logs\2017-11-10T11_02_20_284Z-debug.log

After python installed:

$ npm it

> @risingstack/[email protected] preinstall C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
> node -e 'process.exit(0)'


> @risingstack/[email protected] install C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://oss.risingstack.com/repo/v1/@risingstack/profiler/dist/v5.7.11/node-v57-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/[email protected] and [email protected] (node-v57 ABI) (falling back to source compile with node-gyp)

C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" clean )  else (node "" clean )

C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" configure --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64 )  else (node "" configure --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64 )

C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" build --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64 )  else (node "" build --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64 )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
MSBUILD : error MSB4132: The tools version "2.0" is unrecognized. Available tools versions are "4.0".
gyp ERR! build error
gyp ERR! stack Error: `C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Windows_NT 10.0.16299
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "build" "--fallback-to-build" "--module=C:\\Users\\hf\\Desktop\\dev\\fidelity\\node_modules\\@risingstack\\v8-profiler\\build\\@risingstack\\profiler\\v5.7.11\\node-v57-win32-x64\\profiler.node" "--module_name=profiler" "--module_path=C:\\Users\\hf\\Desktop\\dev\\fidelity\\node_modules\\@risingstack\\v8-profiler\\build\\@risingstack\\profiler\\v5.7.11\\node-v57-win32-x64"
gyp ERR! cwd C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
gyp ERR! node -v v8.9.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp.cmd build --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\node-pre-gyp\lib\util\compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:126:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:925:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
node-pre-gyp ERR! System Windows_NT 10.0.16299
node-pre-gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\hf\\Desktop\\dev\\fidelity\\node_modules\\@risingstack\\node-pre-gyp\\bin\\node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler
node-pre-gyp ERR! node -v v8.9.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.35
node-pre-gyp ERR! not ok
Failed to execute 'node-gyp.cmd build --fallback-to-build --module=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64\profiler.node --module_name=profiler --module_path=C:\Users\hf\Desktop\dev\fidelity\node_modules\@risingstack\v8-profiler\build\@risingstack\profiler\v5.7.11\node-v57-win32-x64' (1)
npm WARN [email protected] requires a peer of ajv@^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @risingstack/[email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @risingstack/[email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\hf\AppData\Roaming\npm-cache\_logs\2017-11-10T11_09_35_790Z-debug.log

Related to bucharest-gold/entente#179

Improve API documentation

JSDoc is such a piece of crap. Well, that's maybe a bit of an exaggeration, but damn it sure is hard to produce good documentation using that tool, unless you let the tool dictate your code style. Whatevs.

Use 'files' property in package.json

This will make sure we just distribute what needs to be there for a runtime, and not the tests and whatnot.

Produce a browser compatible version for releases

I don't think there is any reason to limit this module to node.js

Move repository to bucharest-gold org on github

Handing over the keys

Performance benchmarks

It would be nice to see where fidelity lands in comparison to the other promises implementations.

Add documentation

Currently there's nothing but the README.md

Can't build with node 10x due v8 profiler

Failed to execute '/home/hf/.nvm/versions/node/v10.11.0/bin/node /home/hf/.nvm/versions/node/v10.11.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/hf/Desktop/fidelity/node_modules/@risingstack/v8-profiler/build/@risingstack/profiler/v5.7.11/node-v64-linux-x64/profiler.node --module_name=profiler --module_path=/home/hf/Desktop/fidelity/node_modules/@risingstack/v8-profiler/build/@risingstack/profiler/v5.7.11/node-v64-linux-x64' (1)
In file included from ../src/cpu_profiler.h:6:0,
                 from ../src/cpu_profiler.cc:1:
../../../nan/nan.h:172:10: fatal error: nan_callbacks.h: No such file or directory
compilation terminated.
profiler.target.mk:109: recipe for target 'Release/obj.target/profiler/src/cpu_profiler.o' failed
make: *** [Release/obj.target/profiler/src/cpu_profiler.o] Error 1
make: Leaving directory '/home/hf/Desktop/fidelity/node_modules/@risingstack/v8-profiler/build'

Avoid npm node version warning

After install fidelity we get this message:

npm WARN engine [email protected]: wanted: {"node":"~4.0"} (current: {"node":"4.5.0","npm":"2.15.9"})

Follow automatic-pancake

• Readme bucharest-gold/automatic-pancake#5 (comment)
• Tools - istanbul, semistandard eslint stuff, tape, tap-spec, etc [if applicable - genet, bench...] https://github.com/bucharest-gold/automatic-pancake/blob/master/package.json#L23-L33
• Contributing guide https://github.com/bucharest-gold/automatic-pancake/blob/master/CONTRIBUTING.md
• ES6 with our current techniques

v8 profiler is blocking fidelity update to node 8x

npm ERR! @risingstack/[email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @risingstack/[email protected] install script.

Ignode vscode directory

https://github.com/bucharest-gold/fidelity/tree/master/.vscode

.catch() is not a function

When I changed 'new Promise' to 'Fidelity.promise' I get this error:

..(...).then(...).catch is not a function

Attain parity with ES6 Promises

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise

Edit: Here are the items to add.

• Promise.all https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/all
• Promise.race https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/race
• Promise.reject https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject

Add CONTRIBUTING.md

See: https://github.com/bucharest-gold/automatic-pancake/blob/master/CONTRIBUTING.md

Make private data private

Our underwear is showing

An in-range update of eslint-plugin-import is breaking the build 🚨

Version 2.6.0 of eslint-plugin-import just got published.

Branch	Build failing 🚨
Dependency	eslint-plugin-import
Current Version	2.5.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-import is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

• ❌ coverage/coveralls Coverage pending from Coveralls.io Details
• ❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

---

Commits

The new version differs by 22 commits.

• 8101d39 bump to 2.6.0, node/0.3.1, webpack/0.8.3, memo-parser/0.2.0
• 7f055ec chore(eslint): upgrade to eslint@4
• 0263be4 memo-parser: require eslint >= 3.5.0 (need file path always)
• b1eeade build on node v4, again (#855)
• 14c501e Merge pull request #865 from sompylasar/eslint-module-utils_tests
• 117717f eslint-module-utils: Fix resolver tests for Windows paths
• 314ead8 eslint-module-utils: Fix test coding style
• 2bc4f7f eslint-module-utils: Add test for ignore
• 3b4cb47 eslint-module-utils: Add test for import/resolver config checks
• 06695c4 eslint-module-utils: Add test for when resolver version is not specified
• f65c263 eslint-module-utils: Unified test specs names to not use 'should' word
• a0012f8 eslint-module-utils: Add tests for resolver versions
• 17d2ee9 eslint-module-utils: Add tests for hash utils
• 60b524b Merge commit '3c46d308ccb462a52554257c49c374045d1a6cf7' into file_path_in_parser_options
• 5732742 eslint-module-utils: In tests move require stub parser to the top.

There are 22 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

---

Your Greenkeeper Bot 🌴

Add bluebird benchmark suite

bucharest-gold/entente#133