buchen/fix-info-plist-maven-plugin

Small Maven plugin to "fix" the Info.plist file generated by p2 during a Tycho product build.

fix-info-plist-maven-plugin's Issues

Allow appName parameter to be optional

I was going to use this mojo in a build, but one annoying bit of friction is that our app name changes with minor (m.n) releases because it contains the version as part of its name. Yes, I could derive a property for the app name, but that's already specified somewhere else (the .product file) , and I don't know if Tycho exposes the app name from the .product as a property that could be used for the appName parameter.

I suspect that in a lot of cases, users build only one app in a project, so being able to leave out the appName should be OK as long as there is an app of the given productId around would be really useful.

also updated the prezipped executable?

hi

i just noticed that when i updated or product it reverts the thing that i added in the info.plist

target\org.eclipse.equinox.executable-3.8.1300.v20210828-0802\bin\cocoa\macosx\aarch64\Eclipse.app\Contents

that is because my actual repository product build doesn't have the updated info.plist. (so the repo that i put online)

i do see you try to update the fixed binary:

https://github.com/buchen/fix-info-plist-maven-plugin/blob/master/src/main/java/name/abuchen/mvn/FixInfoPlistMojo.java#L101

but maybe for me that is not generated yet?

i use this plugin in the package phase:

https://github.com/Servoy/servoy-eclipse/blob/master/com.servoy.eclipse.product/pom.xml#L155

What then goes at what point, but it seems to me that something else also needs updating? or that i need todo stuff in a bit later?

How inject array of dict into key value ?

Hi,

I need to inject a dict into my plist, is it possible with your plugin ?

    <key>CFBundleDocumentTypes</key>
    <array>
        <dict>
            <key>CFBundleTypeExtensions</key>
            <array>
                <string>gaml</string>
            </array>
            <key>CFBundleTypeIconFile</key>
            <string>Model.icns</string>
            <key>CFBundleTypeName</key>
            <string>Gama Model</string>
            <key>CFBundleTypeRole</key>
            <string>Editor</string>
            <key>CFBundleTypeOSTypes</key>
            <array>
                <string>TEXT</string>
            </array>
        </dict>
    </array>

Unterstützung für JDK 11

Bei einem Maven-Build mit JDK 11 erhalte ich folgende Fehlermeldung:

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal name.abuchen:fix-info-plist-maven-plugin:1.3:fix-info-plist (fix-info-plist) on project portfolio.product: Execution fix-info-plist of goal name.abuchen:fix-info-plist-maven-plugin:1.3:fix-info-plist failed: A required class was missing while executing name.abuchen:fix-info-plist-maven-plugin:1.3:fix-info-plist: javax/xml/bind/DatatypeConverter
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>name.abuchen:fix-info-plist-maven-plugin:1.3
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/C:/Users/sbaumhekel/.m2/repository/name/abuchen/fix-info-plist-maven-plugin/1.3/fix-info-plist-maven-plugin-1.3.jar
[ERROR] urls[1] = file:/C:/Users/sbaumhekel/.m2/repository/com/googlecode/plist/dd-plist/1.16/dd-plist-1.16.jar
[ERROR] urls[2] = file:/C:/Users/sbaumhekel/.m2/repository/org/tukaani/xz/1.6/xz-1.6.jar
[ERROR] urls[3] = file:/C:/Users/sbaumhekel/.m2/repository/org/codehaus/plexus/plexus-utils/1.1/plexus-utils-1.1.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[project>name.abuchen.portfolio:portfolio-app:0.35.0, parent: ClassRealm[maven.api, parent: null]]]
[ERROR] 
[ERROR] -----------------------------------------------------: javax.xml.bind.DatatypeConverter
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :portfolio.product

Mit JDK 8 funktioniert es einwandfrei.

http://buchen.github.io/maven-repo is not available

http://buchen.github.io/maven-repo is not available
It can not be reached

Binary MD5 hash in "download.checksum.md5" property in artifacts.xml is not updated

The fixZippedBinaryArchiveInRepository(Path infoPlist) method in the FixInfoPlistMojo class does not update the MD5 hash of the binary in the "download.checksum.md5" property because of a spelling error in the code line messageFormat = "<property name=''ownload.checksum.md5'' value=''{0}''/>"; //$NON-NLS-1$.
So far, only the hashes of the properties "download.md5" and "download.checksum.sha-256" are being updated correctly.

Could you provide a new release with a fix for this bug please? That would be great!

Support macOS aarch64 (aka Apple Silicon M1)

As of today, only the Info.plist for the x86_64 builds are fixed

Patch two products

Thanks for this plugin very useful.
Is there a solution to patch two product in the same time ?
Thanks