Remove redundant back-reference to comment in Viewpoint

[buildingsmart]

Remove redundant back-reference to comment in Viewpoint

[pasi-paasiala]

I agree. If someone needs this relation, it is still implicitly available, since comments are linked to viewpoints.

[pasi-paasiala]

Now when looking at this again, it seems that the reference from comment to viewpoint can be removed. Viewpoint can have several comments, so there we need the relation.

[ErikPijnenburg]

I raised this issue to make sure we do not create n:n relations between comments and viewpoints. Your solutions still allows that. When you keep only relation from comment to viewpoint and maxoccurs = 1 then this is taken care of.

[pasi-paasiala]

Currently there's maxoccurs = 1 in the markup schema. See line 119 in https://github.com/BuildingSMART/BCF/blob/master/Schemas/markup.xsd. My question is that did you mean that lines 119 to 123 should be removed? This is the information that I find redundant.

[ErikPijnenburg]

I mean line 38 to 42 need to be removed to solve this,

[pasi-paasiala]

But that is the one to many relation between viewpoints and comments.

[ErikPijnenburg]

Theoretically you could remove either 38-21 (relation from comment to viewpoint, single) or 119-123 (relation from viewpoint to comment, multiple).
If you would remove 119-123 we can still create n:n relations in the file (image the same comment is referred to from two different viewpoints)
If you remove 38-42 we can still create n:1 relation (imagine the same viewpoint is referred to in different comments) but we can never create n:n relations anymore. So that's why I consider this one the best solution.

[pasi-paasiala]

Got you!
Should the minoccurs then be 1 on line 119? Otherwise there can be comments that are not related to any viewpoint.

[ErikPijnenburg]

minoccurs should remain '0' since a comment can be added without adding a new viewpoint or referring to a viewpoint. In theory we can have orphan viewpoints: viewpoint exist in the issue but has no comment pointing to it. This should be avoided by the software creating and managing issues.

[pasi-paasiala]

This is fixed in c3a8930