Giter Site home page Giter Site logo

battlegroundenemies's Introduction

battlegroundenemies's People

Contributors

bullsei avatar wetu avatar wit00 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

battlegroundenemies's Issues

Default blizzard debuff duration

Amazing addon btw, I appreciate all the options you have added.

One addition I would love is for the "blizzard-style" desaturation on buffs/debuffs, like in the image below.

image

Friendly Debuffs Not Visible

I'm having an issue with debuffs on friendly targets not being visible, neither in BGs nor in test mode.

I can see debuffs on the enemies, but no matter which settings I try I'm unable to see friendly ones. I have tried disabling filtering, and enabling filtering with certain spells then testing if those debuffs were shown in a bg, no luck.

I've tried disabling all other addons and downloading buggrabber + bugsack but nothing came up. Curious if you've heard of this issue before or have any ideas what might be causing it.

Also would like to say this is an amazing addon. thank you for all the work you put into it.

Note: Tested with versions of BGE going back to 9.0.4-beta, no changes in behavior.

Disable Arena Frames bugged for Brawl: Packed House

Basically, the ArenaEnemyFrame5 is showing due to what is probably just an oversight due to 5v5 no longer being a bracket.

It's a simple fix, there are 3 blocks of code to hide the default Blizzard UI; they use a for loop to iterate through and disable the default Blizzard frames for cases where BGE is used inside an "arena" All three of these blocks of code use 4 as the upper limit. Changing the 4 to a 5 disables the 5th enemy arena frame, which is currently showing during Brawl: Packed House matches.

Wotlk version doesn't load and is not usable

BattleGroundEnemies/Options.lua:1428: BattleGroundEnemies isn't registed with AceConfigRegistry, unable to open config
[string "=[C]"]: ?
[string "@Masque/Libs/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:1852: in function Open' [string "@BattleGroundEnemies/Options.lua"]:1428: in function ?'
[string "@FrameXML/ChatFrame.lua"]:4938: in function ChatEdit_ParseText' [string "@FrameXML/ChatFrame.lua"]:4601: in function ChatEdit_SendText'
[string "@FrameXML/ChatFrame.lua"]:4637: in function <FrameXML/ChatFrame.lua:4633>
[string "=[C]"]: in function `ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:121_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:121_OnEnterPressed"]:1>

Locals:
(*temporary) = "BattleGroundEnemies isn't registed with AceConfigRegistry, unable to open config"

I use the retail version just fine, but Wotlk version doesn't even open the config menu. It doesn't show up in the addons section. I have tried the older versions, they don't seem to work either.

Shadowlands Update

Thank you for creating this, it's not only been awesome for the causal group but from Sergeants to Heroes

A quote about the issue

"One of the major changes in 9.0 is a change to SetBackdrop. The TL/DR, on live, 100% of frames support backdrops, whether they are used or not. 1000s of frames between every addon and default UI, even frames that never see such as event frames have backdrops. UI team realized this is a serious performance issue. so effective in 9.0, no frames have backdrops unless the addon imports/inherits the backdrop template.
this means addons that aren't importing them now throw nil errors with method "Setbackdrop". This issue affects a large number of addons."

Here is the error codes

Message: ...es\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:189: attempt to call method 'SetBackdrop' (a nil value) Time: Wed Oct 14 13:52:35 2020 Count: 1 Stack: ...es\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:189: attempt to call method 'SetBackdrop' (a nil value) [string "@Interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua"]:189: in function ?'
[string "@interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\AceGUI-3.0.lua"]:107: in function <...s\BattleGroundEnemies\Libs\AceGUI-3.0\AceGUI-3.0.lua:96>
[string "@interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\AceGUI-3.0.lua"]:145: in function Create' [string "@Interface\AddOns\BattleGroundEnemies\Libs\AceConfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua"]:1849: in function Open'
[string "@interface\AddOns\BattleGroundEnemies\Options.lua"]:2270: in function ?' [string "@Interface\FrameXML\ChatFrame.lua"]:5073: in function ChatEdit_ParseText'
[string "@interface\FrameXML\ChatFrame.lua"]:4737: in function ChatEdit_SendText' [string "@Interface\FrameXML\ChatFrame.lua"]:4773: in function ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>

Locals: frame = {
0 =
}
(*temporary) = nil
(*temporary) = {
0 =
}
(*temporary) =

{
bgFile = "Interface\DialogFrame\UI-DialogBox-Background"
tileSize = 32
edgeFile = "Interface\DialogFrame\UI-DialogBox-Border"
tile = true
edgeSize = 32
insets =
{
}
}
(*temporary) = "attempt to call method 'SetBackdrop' (a nil value)"
CreateFrame = defined =[C]:-1
UIParent = UIParent {
0 =
firstTimeLoaded = 1
variablesLoaded = true
}
FrameBackdrop =
{
bgFile = "Interface\DialogFrame\UI-DialogBox-Background"
tileSize = 32
edgeFile = "Interface\DialogFrame\UI-DialogBox-Border"
tile = true
edgeSize = 32
insets =
{
}
}
Frame_OnShow = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:28
Frame_OnClose = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:32
Frame_OnMouseDown = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:36
Button_OnClick = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:23
PaneBackdrop =
{
bgFile = "Interface\ChatFrame\ChatFrameBackground"
tileSize = 16
edgeFile = "Interface\Tooltips\UI-Tooltip-Border"
tile = true
edgeSize = 16
insets =
{
}
}
StatusBar_OnEnter = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:71
StatusBar_OnLeave = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:75
Title_OnMouseDown = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:40
MoverSizer_OnMouseUp = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:45
SizerSE_OnMouseDown = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:56
SizerS_OnMouseDown = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:61
SizerE_OnMouseDown = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:66
Type = "Frame"
pairs = defined =[C]:-1
methods =
{
OnHeightSet = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:108
OnRelease = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:93
OnWidthSet = defined @interface\AddOns\BattleGroundEnemies\Libs\AceGUI-3.0\widgets\AceGUIContainer-Frame.lua:98
`

BGsize bug

Message: ..\AddOns\BattleGroundEnemies\Main.lua line 1624:
attempt to index field 'bgSizeConfig' (a nil value)
Debug:
[string "@RCLootCouncil\Classes\Services\ErrorHandler.lua"]:149:
...dOns\RCLootCouncil\Classes\Services\ErrorHandler.lua:147
[string "@WagoAnalytics\WagoAnalytics.lua"]:72:
WagoAnalytics\WagoAnalytics.lua:70
[string "=[C]"]: ?
[string "@BattleGroundEnemies\Main.lua"]:1624: UpdatePlayerCount()
[string "@BattleGroundEnemies\Main.lua"]:3310: ?()
[string "@BattleGroundEnemies\Main.lua"]:127:
BattleGroundEnemies\Main.lua:124

target calling

Can automatically set raid target icons for target calling

Is target & setting raid icons calling works for Dragonflight in RBG's?

Add-on interferes with Macro Creation

I have several add-ons installed for WoW. I noticed last week that when I tried to create a new macro I received an error via chat that an add-on interfered and must be disabled. I turned off all add-ons and I could create a new macro. I started turning them on one by one and could create a new macro until I got to battlegroundenemies. This add-on was not allowing me to create a new macros. I disabled it again and I was able to create new macros. I turn it on until I need to create a new macro and then I turn it off. I did not notice this issue until last week and created several macros the week before. Just letting you know of an issue that I noticed as I really love the add-on and it is very helpful in battlegrounds. thanks

Questions..

Hey bullsei

I have no idea how else i should reach out to you than here... I tried looking through your AddOn but i couldnt really find any suitable info, so i thought i would ask here instead.

I really love the AddOn and i was hoping if there was any chance of you helping me out here.

Is it in anyway possible to use your addon as a dependency and use any of your functions in the addOn to recall the DR value of a certain unit in the battleground? E.g. the focus? I was hoping to maybe make some sort of WeakAura to help me out with CCing healers in a BG (primarily my current focus) depending on which DR it is in (immune, 1/2, etc...)

Sorry if this is the wrong place to ask you, but i had no idea where else to reach out to you!

SOD Lua Error

3658x Blizzard_ArenaUI/Blizzard_ArenaUI.lua:93: attempt to index global 'ArenaEnemyFrames' (a nil value)
[string "@Blizzard_ArenaUI/Blizzard_ArenaUI.lua"]:93: in function ArenaEnemyFrames_UpdateVisible' [string "@Blizzard_ArenaUI/Blizzard_ArenaUI.lua"]:179: in function ArenaEnemyFrame_UpdatePlayer'
[string "@Blizzard_ArenaUI/Blizzard_ArenaUI.lua"]:218: in function <Blizzard_ArenaUI/Blizzard_ArenaUI.lua:212>

Locals:
_ = true
instanceType = "pvp"
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'ArenaEnemyFrames' (a nil value)"

Doesn't matter if I turn off the arena tab

It doesn't show HP in numeric and dispellable debuffs

This will be a critical feature so we can quickly glance who the enemies are and what their HP's are. Also just like the WoW default party frame, it would be good to show dispellable debuffs so we can only focus on what to dispel. Last but not least, it'll be nice if we can make the HP bar size different for 10-15 or 25-40 separately.

click casting support?

is there way to enable battlegroundenemies to work with blizzard's default click casting?

Addon Does Not Work With Some Wow Accounts

This addon does not function on my brother's account but it does on mine. I logged into his account on my computer and my account on my computer. Upon logging into wow his instance of the game pops up an empty BattleGroundEnemiesNews frame while mine does not. His instance of the game does nothing when I type in /bge, my accounts instance of the game pops up the Test mode interface when I type in /bge.
Trying to use this addon performs exactly the same on his computer as it does on mine. It's not an issue with the addon version, his hardware, or in game settings as those are all the same when I log into his account on my computer or his computer.

Classic TBC same faction BGs issues

In same faction BGs the api call UnitFactionGroup("player") does not return the faction the player plays as but rather your normal faction. But it's possible to check if the player is playing as the opposite faction by checking the players buffs. If they are alliance playing as horde they'll have the Horde buff, with spellID: 81744. If they are horde playing as alliance they'll have the alliance buff with spellID: 81748

Another issue with the same faction BGs is that the scoreboard doesn't return the race of the players in the "mercenary mode". So the check with GetBattlefieldScore for race doesn't work in same faction BGs in TBC since the mercenary mode players cannot become populated with your CreateOrUpdatePlayer call as it requires a valid race. I've made a dirty fix for myself to set every unknown race to Orc. But I assume you'd have to check races with UnitTarget's with the way it works right now if you want to display correct racials for mercenary players.

The mapID for Netherstorm in TBC is 1956
Spell id for flag is still 34976 though

The mapID for Warsong Gulch in TBC is 1460
Alliance flag has spellid: 301091
Horde flag has spellid: 301089

"Higher transparency when out of set Range" Issue.

Hey!

Seems lika an addon do not see "range" and "Higher transparency when out of set Range" do not work after 10.2 update.
Is it possible to fix, or Blizzard blocked something in 10.2?

BTW addon is awesome thanks for your work!

focus on rclick, supported?

thanks for this addon, I'm going to try it in arena and replace default frames and gladiusex, however before doing so I figured I'll ask here because I did not find a related option: are the frames clickable somehow? Ideally I'd like to right click to set a focus.

I've seen 3b674b6 so I guess it should work?

Filtering for Debuff has some bugs:

Filter by Dispellability isn't working (it's showing the debuffs regardless of dispellability status)
Filter by Debuff type isn't working (it's showing all the types of debuffs regardless of debuff type selected)
Filter by SpellID isn't working at all. Although its possible I could be entering the incorrect SpellID, I tried entering all the different possibilities for a Moonfire and nothing worked.

Edit: I love your addon! It's great, and I didn't want to forget to include my gratitude.

No Longer Supported??

This seems to be no longer supported on WotLK Classic as well as the Curseforge Client. Please update or fix this!!! This addon is a MUST for pvp

Lua Error After Update 9.0.2.7-34-g67c5f9a

2x AceLocale-3.0-6: BattleGroundEnemies: Missing entry for 'secondaryDesc'
[string "@BattleGroundEnemies\Options-Options.lua"]:1881: in function `SetupOptions'
[string "@BattleGroundEnemies\Main.lua"]:2000: in function `?'
[string "@BattleGroundEnemies\Main.lua"]:91: in function <BattleGroundEnemies\Main.lua:88>

Occurring since TargetCalling_Highlight.args.Icon.name and TargetCalling_Highlight.args.Icon.desc are using i18n variables that aren't defined.

10.2 Addon Action Blocked Error

11/25/2023 -

Addon Version
10.0.2.6

Game Version: 10.2.0.52188, Retail, US, English

I have been receiving the following error at random in all sorts of content, from open-world content to dungeon content, not just BG's or instanced PvP.

~

1x [ADDON_ACTION_BLOCKED] AddOn 'BattleGroundEnemies' tried to call the protected function 'IsItemInRange()'.
[string "@!BugGrabber/BugGrabber.lua"]:481: in function <!BugGrabber/BugGrabber.lua:481>
[string "=[C]"]: ?
[string "@BattleGroundEnemies/Main.lua"]:523: in function UpdateAll' [string "@BattleGroundEnemies/Main.lua"]:606: in function NewUnitID'
[string "@BattleGroundEnemies/Main.lua"]:3993: in function UpdateAllUnitIDs' [string "@BattleGroundEnemies/Main.lua"]:4042: in function GROUP_ROSTER_UPDATE'
[string "@BattleGroundEnemies/Main.lua"]:2737: in function ?' [string "@Accountant_Classic/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...sic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109> [string "=[C]"]: ? [string "@Accountant_Classic/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...sic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Accountant_Classic/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function Fire'
[string "@BattleGroundEnemies/Libs/LibGroupInSpecT-1.1-92/LibGroupInSpecT-1.1.lua"]:671: in function `eventhandler'
[string "@BattleGroundEnemies/Libs/LibGroupInSpecT-1.1-92/LibGroupInSpecT-1.1.lua"]:129: in function <...ies/Libs/LibGroupInSpecT-1.1/LibGroupInSpecT-1.1.lua:127>

Locals:
_ = Frame {
RegisterEvent = defined @!BugGrabber/BugGrabber.lua:487
0 =
UnregisterEvent = defined @!BugGrabber/BugGrabber.lua:487
SetScript = defined @!BugGrabber/BugGrabber.lua:487
}
event = "ADDON_ACTION_BLOCKED"
events =

{
ADDON_ACTION_BLOCKED = defined @!BugGrabber/BugGrabber.lua:553
ADDON_ACTION_FORBIDDEN = defined @!BugGrabber/BugGrabber.lua:553
PLAYER_LOGIN = defined @!BugGrabber/BugGrabber.lua:547
LUA_WARNING = defined @!BugGrabber/BugGrabber.lua:562
ADDON_LOADED = defined @!BugGrabber/BugGrabber.lua:507
}

~

Screenshots below are from BugGrabber / BugSack:
11-25-2023 BG Enemies Error (1)
11-25-2023 BG Enemies Error (2)
11-25-2023 BG Enemies Error (3)

Medallions are not working

Since Pre-Patch, Medallion changed to an item, [Corrupted Aspirant's Medallion] and is not registering.

I imagine the same applies for [Corrupted Aspirant's Sigil of Adaptation]

Nolib

Can you enable nolib in pkgmeta for nolib users?

check players in group with addon

this is more of a feature request, would be really nice to have a button in BGE to allow us to check which players have or do not have it installed - also, never done LUA development so if there are any pointers you can provide (in terms of API on how to implement) I'd be happy to stop for a couple hours to implement and PR.

Does not work in RBGS

Scoreboards do not populate until after the match.
Possible fix would be to use the combat log, like Spy.

Trinkets aren't working!

Hey! I absolutely -LOVE- your addon! I've been using it every since Battleground Targets stopped working after Legion. After pre-patch, I believe, I noticed it stopped tracking trinkets! I don't know if this is due to trinkets changing from an honor talent to an actual item or just something weird on Blizzard's end! Thank you.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.