burningice2866/compositec1contrib.security

compositec1contrib.security's Issues

Workflow error when trying to add new user

Hey,

Running on the official Composite C1
Build no. 5.0.6029.22524

I get this error when i try to add a new user via. the security module on the system page:
Interestingly it does actually add the user

InvalidOperationException:
Error executing workflow fb2c6666-e9ba-4d75-9ccf-c636acf2b930
Stack trace:
   at Composite.C1Console.Workflow.WorkflowFacadeImpl.RunWorkflow(Guid instanceId) in C:\tmp\SIMPortalen\Composite\C1Console\Workflow\WorkflowFacadeImpl.cs:line 279
   at Composite.C1Console.Workflow.WorkflowFacade.RunWorkflow(Guid instanceId) in C:\tmp\SIMPortalen\Composite\C1Console\Workflow\WorkflowFacade.cs:line 140
   at Composite.C1Console.Workflow.WorkflowFlowController.OnFinish(FlowToken flowToken, Dictionary`2 bindings, FlowControllerServicesContainer serviceContainer) in C:\tmp\SIMPortalen\Composite\C1Console\Workflow\WorkflowFlowController.cs:line 273
   at Composite.Core.WebClient.FlowMediators.FormFlowRendering.FormFlowUiDefinitionRenderer.BaseEventHandler(String consoleId, String elementProviderName, FlowToken flowToken, FormFlowUiDefinition formFlowUiCommand, FlowControllerServicesContainer servicesContainer, Dictionary`2 eventHandlers, IFormEventIdentifier localScopeEventIdentifier, Flo
ArgumentNullException:
Value cannot be null.
Parameter name: flowControllerServicesContainer
Stack trace:
   at Composite.Verify.ThrowArgumentNullException(String parameterName) in C:\tmp\SIMPortalen\Composite\Verify.cs:line 173
   at Composite.Verify.ArgumentNotNull(Object value, String paramName) in C:\tmp\SIMPortalen\Composite\Verify.cs:line 26
   at Composite.C1Console.Actions.AddNewTreeRefresher..ctor(EntityToken parentEntityToken, FlowControllerServicesContainer flowControllerServicesContainer) in C:\tmp\SIMPortalen\Composite\C1Console\Actions\AddNewTreeRefresher.cs:line 25
   at Composite.C1Console.Workflow.Activities.FormsWorkflow.CreateAddNewTreeRefresher(EntityToken parentEntityToken) in C:\tmp\SIMPortalen\Composite\C1Console\Workflow\Activities\FormsWorkflow.cs:line 649
   at CompositeC1Contrib.Security.C1Console.Workflows.AddUserWorkflow.OnFinish(Object sender, EventArgs e) in C:\tmp\SIMPortalen\C1.contrib.security\Security\C1Console\Workflows\AddUserWorkflow.cs:line 54

Log off routine fails in session state is disabled

Log off routine fails in session state is disabled due to a missing null-check here

https://github.com/burningice2866/CompositeC1Contrib.Security/blob/master/Security/Web/ResponseHandler.cs#L59

Workaround is to ensure enableSessionState in web.config is set to true

Adding AfterLoginPage field to security settings Datatype

I would be nice to have a AfterLoginPage field to the security settings so you can assign that page directly into the security settings when you are adding the login page.

Can you add StartupHandler to Security package too

Hi, we have been communicating now for a while. I would like to ask, if you could also add the StartupHandler instead of OwinExtension to your Security package too, which would initiate datatypes in C1CMS.

using Composite.Core.Application;
using Composite.Data.DynamicTypes;
using CompositeC1Contrib.Security.Data.Types;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace CompositeC1Contrib.Security
{
    [ApplicationStartup]
    public sealed class StartupHandler
    {
        public static void OnBeforeInitialize() { }

        public static void OnInitialized()
        {
            DynamicTypeManager.EnsureCreateStore(typeof(IMembershipUser));
            DynamicTypeManager.EnsureCreateStore(typeof(IDataPermissions));
            DynamicTypeManager.EnsureCreateStore(typeof(IWebsiteSecuritySettings));
        }
    }
}

Also the Extranet provider is not visible from C1. All other stuff seems working now. I just need this one little tab to be visible, then this package would be fine again.

Thanks,
Jaan