buvsethia/nbapbpgraphs

Create graphs from NBA.com's play by plays

nbapbpgraphs's Issues

Loading a new graph and trying to play with it causes graph to flicker between new one and old one (if old one exists)

Roster lists need to be generated from boxscore and not roster endpoint

Since trades could change a roster on a game by game basis, we need to get game roster from the box score for that game.

PBP doesn't always differentiate between players with the same last name.

For example, if Tyler Johnson and James Johnson both have a steal in a game, the PBP row for both of those steals would just be Johnson STEAL. No way to tell which Johnson had the steal. This could be an app-breaking issue...

Implement get_roster

To do.

Detemining rebound type for whole team line generation for OREB and DREB

If you're trying to generate a whole team line for OREB and DREB, whenever you come across a rebound row, how can you tell if it was an offensive or defensive rebound without knowing the previous rebound row for that player. You'd have to create a hacky persistent rebound dictionary or something like that to keep track of rebounds for each player over the course of graph generation...

Markieff Morris' PBP name is Mark Morris, which messes with data generation for him

The current stat extraction for multiple stats will fail on some rows involving Markieff Morris (and most likely Marcus Morris as well, need to test).

Don't include DREB data points on OREB graph and vice versa

When graphing OREB, every DREB grabbed gets a data point with the same value as the previous data point (and vice versa). Consider finding a workaround for this so that each rebound graph remains "pure".