buxorg/bux

Bitcoin UTXO & xPub Management Engine

bux's Issues

Support Multiple Servers for Monitoring

• Add a locking mechanism when Monitor is loaded (establish a lock if not found)
• Create a heart beat, write into the lock
• On disconnect or close, remove the lock
• All servers that are not monitoring are try to see if a lock is established, if not, create and start Monitoring

Initial token support in Bux

Feature: test-net support

• Requires new go-bitcoin v2
• Update any models that are looking at addresses, destinations or other strings that might be different
• Broadcasting package support
• Paymail (internal support - IE: running a paymail server)
• Paymail (external support - IE: interacting with external service providers, like MoneyButton)

[Bug]: Syncing transactions on-chain fails with inputs missing

What happened?

Transactions are broadcast in order, if a transaction is successfully broadcast, the next one should also succeed.

How can we reproduce this?

It's sporadic

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

No response

Fix code scanning alert: Incorrect conversion between integer types

Tracking issue for:

• https://github.com/BuxOrg/bux/security/code-scanning/1

[Bug]: 422 Error when xpub current_balance gets below 0 - sqlite

What happened?

I'm not 100% on repro steps yet in terms of causing the xpub current_balance to get below 0, but if it does happen with sqlite then you can see error as shown in the attached logs when go-datastore attempts to read the value.

How can we reproduce this?

Set xpub current_balance below 0 and run a command with bux that would select the xpub and read its current_balance field and watch it panic.

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

2022/09/19 23:02:26 type="error" file="[email protected]/models.go" method="go-datastore.(*Client).IncrementModel.func1" line="111" message="error executing query" file="/home/galt/go/pkg/mod/github.com/mrz1836/[email protected]/models.go:111" error="sql: Scan error on column index 5, name "current_balance": converting driver.Value type int64 ("-15") to a uint64: invalid syntax" duration="0.116ms" rows="1" sql="SELECT * FROM `xapi_xpubs` WHERE id = "7bd748da2721f4bcc7908a987c0c700c55b93deb55f02bae50777bc97882190b" ORDER BY `xapi_xpubs`.`id` LIMIT 1 "
2022/09/19 23:02:26 type="info" file="bux/models_internal.go" method="bux.(*Model).DebugLog" line="38" message="save tx error: sql: Scan error on column index 5, name "current_balance": converting driver.Value type int64 ("-15") to a uint64: invalid syntax"

Feature: get xPub using cache

First try to get the xPub from cache

If that fails, get from DB and then warm the cache for next time

Feature: Import an existing xPub

• New import package in bux
• Import an existing xPub
• Builds all data models: xpub, transaction, destinations, utxos
• Test the importer (same balance, all utxos, correct state)
• Save the block height and block hash
• Save additional metadata from the import

Feature: add merkle proof to transaction model

Ability to save the merkle proof and validate

Feature: mAPI support / auto-quote gathering

• mAPI service provider
• Auto-fetch quotes per miner
• Use the user provided fee/rate/token (or use a strategy: best quote, fastest)
• How to handle if a quote/miner is lower then the failover miner for broadcast?

Cachestore improvements

• Remove mCache (not thread safe) (or fork and try to fix?)
• Create a interface for cachestore so someone else can extend
• Implement freecache

[Question]: What is the reason to treat broadcast providers differently?

Context

Currently in bux/chainstate/broadcast.go, line 67: broadcast( (...) ) the system tries to broadcast tx to several different providers:

1. few providers via mAPI
2. WhatsOnChain
3. NowNodes

Question

What is the reason to call WhatsOnChain and NowNodes api without a set timeout for the connection, while timeout is set for requests to mAPI?

Code

Call to mAPI broadcast:

Call to WhatsOnChain broadcast:

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

No response

[docu]: Documentation not loading because of BSV License

https://pkg.go.dev/github.com/BuxOrg/bux

[Bug]: Transaction seems to be synced, not found on chain

What happened?

Example: f850a716343651a227fb755a2da903790c249cd2fe2e068cab6e25a6a3e3bffb

Another problem with this one is that the sync tries forever and fills the results field in MySQL with JSON that at a certain moment is not readable anymore.

How can we reproduce this?

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

No response

After creating a destination with monitor enabled, monitor fails to add filter

1. Create a new destination (while having monitor turned on/enabled)
2. in the AfterCreated() method, monitor.Add() is fired (model_destinations.go:347)
3. error occurs: client was expected but not found

It seems that the client on the monitor is not found...?

BUX Admin Console to MVP

• Admin Paymail support
• Admin Xpub, Destination, Utxo etc. support
• Admin dashboard
• • Status (nr of xpubs, destinations, utxos, paymail)
• • Nr transactions per week

Ability to Start and Stop a Monitor

Similar to other clients, we need the ability to do: monitor.Start() or monitor.Stop()

• close the active web sockets
• close any running go routines

Feature: Broadcasting & On-chain Sync Support

REQUIRED:

• Config option to turn off/on broadcasting (entire bux client vs per tx)
• Bring your own client(s) (Minercraft) (WOC) (MatterCloud)
• Basic state management of TX (broadcast or not, state of the broadcast, in-block etc)
• Mocking of all providers
• Use your own mAPI tokens
• Broadcast using: mAPI
• Broadcast using: WhatsOnChain
• Broadcast using: MatterCloud
• Broadcast using: NowNodes
• Use your own fees (rework: GetFeeUnit())
• No fee set? How do we auto-get fees?
• Finalize the mvp SyncConfig rules
• Create new task: broadcast
• Create new task: sync
• Understanding if it's a P2P TX (use paymail broadcasting)

[Bug]: possibility to create many identical paymails

What happened?

There is possibility to create many paymails with this same alias and domain, example: [email protected]

Solution proposal:

• Check if paymail already exist before creating new one

How can we reproduce this?

Use endpoint from bux-server:

• POST /v1/paymail

With data:

{
  "key": "...",
  "address": "[email protected]",
  "public_name": "test",
  "avatar": "test"
}

Call it many times and many this same paymails will be created

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

No response

[Bug]: Transaction can be broadcast out of order - check if parent is done before broadcasting

What happened?

Missing inputs error when broadcasting

How can we reproduce this?

Hard to run into, it's related to parent tx not being broadcast and the child being broadcast before.

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

No response