Add support for other HW RTCs

[bxparks]

Add support for other HW RTCs

[bxparks]

Hi, Thanks for the suggestions! Unfortunately, I don't have the DS1307 or the DS3232, and I don't feel comfortable adding untested code. But if someone who can actually test on those chips wants to contribute some code, I'd be happy to look at the PR.

[Naguissa]

Hello again,

I don't have none of them, but if you check datasheets DS3232 have just same control registers as DS3231, the only change is that it adds some SRAM after all control registers (same kind of SRAM as old DS1307 has).

Cheers!

[bxparks]

Yeah... I don't work like that, I only publish tested code.
I'll keep this issue open in case I get my hands on one of these other chips, or someone else contributes some code. If these other chips are as close to the DS3231 as you say, then it should be easy for someone to modify my current code for those chips.

[Naguissa]

Perfect!

Let's hope anyone can test it, it'squite simple but you need the real hardware.

But one note, the identical one is DS3232, the other one changes a little.

Cheers!

[Naguissa]

Other thing: I'll try to add the code and make a PR, but I cannot test it.

[bxparks]

But if you can't test it yourself, I'd be reluctant to accept that PR...

[Naguissa]

Can'tyou make a branch and ask any user to test it?

[bxparks]

But why would I want to deal with the extra hassle and support requests from the users, for a chip that I don't have and can't test on? I wrote this for fun and for what I need, not because I want to provide free support for users.

I'd be willing to accept your PR if you put a big warning "THIS IS UNTESTED", and you placed your email address in it so that people can send you support requests. :-)

[Naguissa]

I'll do! even adding a compiler message.

PS: I'm CTO in a company, Arduino and electronics is only my hobby.

[Naguissa]

Checked. No code change is needed, only adding compatibility info.

[Naguissa]

(Oh! And I've made a PR. Consider changing the texts to fit your wishes)

[bxparks]

Merged 834fe7a. I think we can close this?