Comments (5)
You need to modify the bck_driver enum at the top of that file, as well as the selection mechanism (relating to sysfs_backlight_probe). (If you don't want to take this on, I can probably get to it later this week and hand you a patch to test.)
from pommed-light.
Ok, here's the complete patch including the enum fix:
--- sysfs_backlight.c 2014-02-22 18:32:50.552133444 +0100
+++ sysfs_backlight.c 2014-02-26 23:51:33.034948626 +0100
@@ -46,6 +46,7 @@
SYSFS_DRIVER_APPLE,
SYSFS_DRIVER_NVIDIA,
SYSFS_DRIVER_NOUVEAU,
- SYSFS_DRIVER_INTEL,
SYSFS_DRIVER_ACPI,
#endif
SYSFS_DRIVER_MAX
@@ -70,6 +71,7 @@
"/sys/class/backlight/apple_backlight/actual_brightness",
"/sys/class/backlight/nvidia_backlight/actual_brightness",
"/sys/class/backlight/nv_backlight/actual_brightness", - "/sys/class/backlight/intel_backlight/actual_brightness",
"/sys/class/backlight/acpi_video0/actual_brightness",
#endif
};
@@ -89,6 +91,7 @@
"/sys/class/backlight/apple_backlight/brightness",
"/sys/class/backlight/nvidia_backlight/brightness",
"/sys/class/backlight/nv_backlight/brightness", - "/sys/class/backlight/intel_backlight/brightness",
"/sys/class/backlight/acpi_video0/brightness",
#endif
};
@@ -108,6 +111,7 @@
"/sys/class/backlight/apple_backlight/max_brightness",
"/sys/class/backlight/nvidia_backlight/max_brightness",
"/sys/class/backlight/nv_backlight/max_brightness", - "/sys/class/backlight/intel_backlight/max_brightness",
"/sys/class/backlight/acpi_video0/max_brightness",
#endif
};
Not sure what should be changed in sysfs_backlight_probe() or friends as they seem to work OOTB - even after closer inspection :-). But maybe I'm missing something here..
from pommed-light.
Does this patch work without acpi_backlight=vendor? I was guessing that even with the enum fix, you'd need to change some part of the selection mechanism. However, if this works correctly for you, it's almost certainly correct, and I'll merge it in.
from pommed-light.
Managed to find some time to give it another spin. After fixing the enum it also now works w/o the kernel boot parameter. Just don't use a step value of 1 in the pommed.conf file with the Intel driver -); otherwise you will be waiting forever as possible values for the backlight driver range from 1 to 1808. A step value of 10 to 20 does the trick though.
from pommed-light.
Ok, I've pushed this patch, so I'm closing this issue. Thanks loads!
from pommed-light.
Related Issues (18)
- Add support for MacBookAir 2012 HOT 1
- Crash on Macbook Air -08 "Could not map GMA950/GMA965 memory" HOT 10
- Trouble compiling HOT 6
- Support for MacBookPro 9,2 HOT 2
- E: Unknown Apple machine: MacBookAir6,2 HOT 9
- E: Could not map GMA950/GMA965 memory HOT 1
- Unknown apple machine: MacBookPro11,1 HOT 1
- E: Unknown Apple machine: MacBookPro12,1 HOT 5
- core-dump when starting pommed before sound card is ready HOT 2
- Unknown Apple machine: MacBookPro11,5 HOT 3
- Support for MacbookAir7,2 (and 7,1) HOT 10
- Macbook Pro 8,2: keyboard evdev discarded HOT 4
- LCD backlight probe fails on boot but not on restart HOT 4
- Outdated version macro M_VERSION in pommed.h
- Cut a new release? HOT 1
- KBD_TIMEOUT is too low, causes too many CPU usage
- Only works in TTY and only 3 brightness steps HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pommed-light.