bytbox/pommed-light

A trimmed version of the pommed hotkey handler for macbooks

pommed-light's Issues

Trouble compiling

I am on Debian testing. My build fails and it looks like I have conflicting header files.
What can I do about this?

$ make
make -C pommed OFLIB=
make[1]: Entering directory `/usr/local/src/pommed-light/pommed'
gcc -g -O2 -Wall  -I/usr/include/alsa       -DNO_SYS_INOTIFY_H -DNO_SYS_TIMERFD_H   -c -o evdev.o evdev.c
In file included from /usr/include/x86_64-linux-gnu/asm/fcntl.h:1:0,
                 from /usr/include/linux/fcntl.h:4,
                 from /usr/include/linux/inotify.h:11,
                 from evdev.c:37:
/usr/include/asm-generic/fcntl.h:171:8: error: redefinition of ‘struct flock’
In file included from /usr/include/fcntl.h:35:0,
                 from evdev.c:25:
/usr/include/x86_64-linux-gnu/bits/fcntl.h:35:8: note: originally defined here
make[1]: *** [evdev.o] Error 1
make[1]: Leaving directory `/usr/local/src/pommed-light/pommed'
make: *** [pommed] Error 2

acpi_video0 backlight vs. intel_backlight

On a stock Lubuntu 13.10 running on a MBP 8,1 I noticed that using acpi_video0 in /sys/class/backlight to control the backlight doesn't seem to work (kernel 3.13). In contrast to this, intel_backlight does seem to work.

As a quick workaround, inserting the respective /sys/class files in sysfs_backlight.c does the trick:

--- sysfs_backlight.c.org 2014-02-22 18:32:50.552133444 +0100
+++ sysfs_backlight.c 2014-02-22 18:06:00.186953043 +0100
@@ -70,6 +70,7 @@
"/sys/class/backlight/apple_backlight/actual_brightness",
"/sys/class/backlight/nvidia_backlight/actual_brightness",
"/sys/class/backlight/nv_backlight/actual_brightness",

• "/sys/class/backlight/intel_backlight/actual_brightness",
  "/sys/class/backlight/acpi_video0/actual_brightness",
  #endif
  };
  @@ -89,6 +90,7 @@
  "/sys/class/backlight/apple_backlight/brightness",
  "/sys/class/backlight/nvidia_backlight/brightness",
  "/sys/class/backlight/nv_backlight/brightness",
• "/sys/class/backlight/intel_backlight/brightness",
  "/sys/class/backlight/acpi_video0/brightness",
  #endif
  };
  @@ -108,6 +110,7 @@
  "/sys/class/backlight/apple_backlight/max_brightness",
  "/sys/class/backlight/nvidia_backlight/max_brightness",
  "/sys/class/backlight/nv_backlight/max_brightness",
• "/sys/class/backlight/intel_backlight/max_brightness",
  "/sys/class/backlight/acpi_video0/max_brightness",
  #endif
  };

Caveat: I don't know why yet, but in order to make this work, acpi_video0 cannot
be present in the backlight directory, so acpi_backlight=vendor as a kernel parameter has to be stated during boot.

E: Unknown Apple machine: MacBookPro12,1

Just got my new retina MacBook Pro (Early 2015) and would like to add support for my generation to pommed. Where do I start?

Add support for MacBookAir 2012

The model indicated in /sys/class/dmi/id/product_name is "MacBookAir5,1"

Only works in TTY and only 3 brightness steps

Currently on a macbook pro (mid 2010) using pommed because nvidia-bl is no longer working for some reason. The brightness keys don't seem to work at all unless i am in a TTY, they have no effect in GDM or the DE (cinnamon). However, if I adjust the brightness while in a TTY, the brightness change stays when switching back to cinnamon or GDM. Also, there are only 3 brightness steps, how can I have more steps, and why does it not work in cinnamon/GDM?

pommed -d output: https://haste.gradyn.com/95hE1YTuQK.makefile

core-dump when starting pommed before sound card is ready

No problems if I restart the service after boot, so this seems to be a race condition.
boot_fail_log.txt
boot_fixed_log.txt
pommed.service.txt

To save you digging through the logfiles to check:
Arch Linux
MacBookPro5,5

Attached are logs before and after I changed the pommed.service file to set After=sound.target, and WantedBy=sound.target
Not the most elegant approach (since it assumes we are using the volume control hotkeys).

Macbook Pro 8,2: keyboard evdev discarded

In line 51 of my log, you can find that the internal keyboard is discarded. This is because its product ID (0x0252) is not between the ones in evdev.h. Any idea why my product id is not in the list? Maybe it's a typo (0x0262 instead of 0x0252)?

Note: my keyboard has been replaced in the past, so this might be the reason why it's not "Wellspring V" but "Apple Internal Keyboard / Trackpad".

Cut a new release?

Looks like it's been just about 2 years since the last release. Are there plans to cut a new release soon? Would be nice to see #26 and #28 released.

E: Could not map GMA950/GMA965 memory

DMI vendor name: [Apple Inc.]
DMI product name: [MacBook4,1]
System: Linux 3.16.3-gentoo-core2 x86_64
GMA950/GMA965 PCI resource: [/sys/bus/pci/devices/0000:00:02.0/resource0], length 1024K
E: mmap failed: Resource temporarily unavailable
E: Could not map GMA950/GMA965 memory
E: LCD backlight probe failed, check debug output
I: pommed v1.45lw Apple laptops hotkeys handler
I: Copyright (C) 2006-2011 Julien BLACHE [email protected]
pommed configuration:

• General settings:
  fnmode: 1
• sysfs backlight control:
  initial level: -1
  step: 1
  on_batt: 6
• ATI X1600 backlight control:
  initial level: -1
  step: 10
  on_batt: 80
• Intel GMA950 backlight control:
  initial level: 0xffffffff
  step: 0xf
  on_batt: 0x40
• nVidia GeForce 8600M GT backlight control:
  initial level: -1
  step: 1
  on_batt: 6
• Audio volume control:
  card: default
  initial volume: -1
  step: 10%
  beep: yes
  volume element: PCM
  speaker element: Front
  headphones element: Headphone
• Keyboard backlight control:
  default level: 100
  step: 10
  auto on threshold: 20
  auto off threshold: 40
  auto enable: yes
  idle timer: 60s
  idle level: 0
• CD eject:
  enabled: yes
  device: /dev/dvd
• Beep:
  enabled: no
  beepfile: /usr/share/pommed/goutte.wav
• Apple Remote IR Receiver:
  enabled: no
  I: DMI machine check: running on a MacBook4,1

E: Unknown Apple machine: MacBookAir6,2

How or where do I get support for a Macbook Air Early 2014? Many thanks,

http://dabase.com/blog/Macbook_Air_Early_2014_Archlinux/

Support for MacBookPro 9,2

Hi!

Is it possible to add support for MacBookPro 9,2? I made a fork and tried, however, I get the following error: "E No suitable event devices found". I get that the changes I made (basically just add a new Enum-value and a strcmp) are not enough. What is needed to make it work?

Best regards,
Isak

Outdated version macro M_VERSION in pommed.h

Macro is outdated. Right now it says #define M_VERSION "1.45lw"

Crash on Macbook Air -08 "Could not map GMA950/GMA965 memory"

Debug output: http://pastebin.com/1xwMwe59

The relevant error:
E: mmap failed: Resource temporarily unavailable
E: Could not map GMA950/GMA965 memory
E: LCD backlight probe failed, check debug output

Running on Linux 3.8.11, (Arch Linux with systemd).

It used to work a few months ago when I last used linux on this machine, but I could not say which version.

Also tried the pommed arch packages pommed and pommed-git, but they give the same error.

Support for MacbookAir7,2 (and 7,1)

Hoping to get this added to the support list. Not sure that much changed from 6,1/2.

Unknown apple machine: MacBookPro11,1

Ive got a very new (either late 2014 or early 2015) macbook pro that pommed doesnt seem to recognize.

LCD backlight probe fails on boot but not on restart

I enabled the pommed.service but it fails (only) after boot:

E: sysfs backlight probe failed, no fallback for this machine
E: LCD backlight probe failed, check debug output

But if I systelctl restart pommed, pommed starts and runs good.

Otherwise, when nvidia-bl is installed (with apple_bl kernel module disabled), pommed does not crash after boot but the screen backlight Fx keys (and only them) have no effect.

PS : Et merci pour le travail fourni jusqu'ici ! 👍

Unknown Apple machine: MacBookPro11,5

/usr/bin/pommed -d
I: pommed v1.45lw Apple laptops hotkeys handler
I: Copyright (C) 2006-2011 Julien BLACHE [email protected]
pommed configuration:

• General settings:
  fnmode: 1
• sysfs backlight control:
  initial level: -1
  step: 1
  on_batt: 6
• ATI X1600 backlight control:
  initial level: -1
  step: 10
  on_batt: 80
• Intel GMA950 backlight control:
  initial level: 0xffffffff
  step: 0xf
  on_batt: 0x40
• nVidia GeForce 8600M GT backlight control:
  initial level: -1
  step: 1
  on_batt: 6
• Audio volume control:
  card: default
  initial volume: -1
  step: 10%
  beep: yes
  volume element: PCM
  speaker element: Front
  headphones element: Headphone
• Keyboard backlight control:
  default level: 100
  step: 10
  auto on threshold: 20
  auto off threshold: 40
  auto enable: yes
  idle timer: 60s
  idle level: 0
• CD eject:
  enabled: yes
  device: /dev/dvd
• Beep:
  enabled: no
  beepfile: /usr/share/pommed/goutte.wav
• Apple Remote IR Receiver:
  enabled: no
  DMI vendor name: [Apple Inc.]
  DMI product name: [MacBookPro11,5]
  E: Unknown Apple machine: MacBookPro11,5
  E: Unknown Apple machine

KBD_TIMEOUT is too low, causes too many CPU usage

pommed-light/pommed/kbd_backlight.h

Line 25 in 0bb24c3

#define KBD_TIMEOUT 200

I usually set

#define KBD_TIMEOUT 2000