bytehamster/sichash

A (Minimal) Perfect Hash Function based on irregular cuckoo hashing, retrieval, and overloading.

sichash's Issues

Missing <tbb/concurrent_queue.h>

Hi @ByteHamster ,

While trying to use your library as a submodule of lphash I am unable to include <tbb/concurrent_queue.h> .
I tried using sudo apt install libtbb-dev on a Ubuntu box without success.

Can you please tell me how you installed it?

Thanks in advance.

ssh key required when cloning submodules

Hello @ByteHamster,

Cloning recursively SicHash as a submodule of another project fails.
SicHash itself is imported correctly, but downloading its submodules (namely: simpleRibbon and util) fails due to permission issues.

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists.

I think the culprit is that ssh is used instead of https, e.g. :

SicHash/.gitmodules

Line 3 in de0d010

url = [email protected]:ByteHamster-etc/sux.git

Would it be possible to switch to https?

Improve labels

It would be VERY useful if you could clearly label the graphs in the README as construction times. Anybody will expect query times there (there's no label). I lost quite some time and had to go through the paper to understand why the results looked completely absurd to me...