c-bertran/42-exam-shell

Examshell will allow you to practice to be perfectly ready for the 42 exams

42-exam-shell's Issues

Expected outcome of microshell's example differs from what happens in bash

Describe the bug
In microshell's subject (/srcs/exams/04/microshell/subjects/fr_FR), the examples suggest that the second occurrence of echo should be interpreted as a command, hence there should be a second line of output.

$>./microshell /usr/bin/echo WOOT "; microshell ;" "; ;" ";" /usr/bin/echo "is hell of fun"
WOOT ; microshell ; ; ;
is hell of fun

Expected behavior
Semicolons shall be interpreted literally inside double quotes, as per the documentation.

The expected subject text should be:

$>./microshell /usr/bin/echo WOOT "; microshell ;" "; ;" ";" /usr/bin/echo "is hell of fun"
WOOT ; microshell ; ; ; ; /usr/bin/echo is hell of fun

as is bash's (see screenshot).

Screenshots

Additional context
Some other examples give misleading guidance and hence should be revised.

ERR_UNHANDLED_REJECTION

═══════════════ ⚠ Error ⚠ ══════════════
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "127".] {
code: 'ERR_UNHANDLED_REJECTION'
}
══════════════════════════════════════════

[Error 121] Under MacOS, automatic installation is unavailable.

[Error 121] Under MacOS, automatic installation is unavailable. Please install git, clang and valgrind manually

I have a High Sierra operating system. I have already installed git, clang and valgrind manually by homebrew but still can not make the installer work.

In get_prime_sum exercise subject says to make get_prime_sum.c in get_prime_sum folder, but examshell when grades is searching for get_prime_sub.c in get_prime_sub folder

Describe the bug
In get_prime_sum exercise subject says to make get_prime_sum.c in get_prime_sum folder, but examshell when grades is searching for get_prime_sub.c in get_prime_sub folder

Bug under MacOS with bash script

Describe the bug
On MacOS, some bash scripts have apparently misunderstood redirects
Checks are in progress

Desktop (please complete the following information):

• OS: MacOS

Exam Checkmate (02-part4)

Describe the bug
The subject of the Exam checkmate (02-part4) seems incorrect.

Expected behavior
The output of the third test should be Fail$ since the king is not in checkmate in this position. Indeed, he is not aligned with the only rook on the board.

Additional context
These lines seem problematic.

EXAM05 bug

Describe the bug
Just launch an empty grademe and got 33/100

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]: macos

Additional context
Add any other context about the problem here.

Dependencies

I believe it's a good idea to add to the README a Dependencies section

The Dependencies section will let any reader know which are the main dependencies that the project uses.
This way the reader will know if he needs to install any dependencies beforehand.
Although this could be arguable since Linux would detect this automatically and prompt the user to install them.

On the other hand I believe this information is useful and it's a good idea to have it on the README
and maybe explain why they are needed.

• node > version
• valgrind > version
• clang > version
• git > version

What do you think?

Fedora & MacOs grademe Error

After installing the project in my computer and running the command grademe, inside the examshell cli the program returned an Error
Error: Command failed: bash make.bash render

Download the program at Releases 0.3.6
Change directory too the downloaded file location.
chmod +x examshell && ./examshell
When the command is executed, the Menu prompts there is a new version available for download
It says:
? Do you want to skip installation step (e.g. a false negative) ? › (y/N)
I decided to choose y (yes)
Then I choose English
Then Infinite
... Exam06
I create and commit the repo on the folder ~render/mini_serv/mini_serv.c
then I prompt grademe and the error is returned.

Desktop (please complete the following information):

• OS: Fedora GNU/LINUX
• Version 37

Can you give more explanation about install process.

I have a hard time understanding the installation part. It would be nice if you could give clear instructions for newbies like me. I tried to download both files but didn't manage to run the examshell.

Exam 4 Trace failed

Describe the bug
I think Exam 4 always fail because code in here can't compile

Expected behavior
Exam ok or another error.

Screenshots

=== TRACE ===
microshell.c:39:32: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
        if (x < 2 || x > 2 || argv[1] && strcmp(argv[1], "-") == 0)
                           ~~ ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
microshell.c:39:32: note: place parentheses around the '&&' expression to silence this warning
        if (x < 2 || x > 2 || argv[1] && strcmp(argv[1], "-") == 0)
                                      ^
                              (                                   )
1 error generated.

Additional context
None