c00p75/js-portfolio

A personal portfolio site that is simple, uses images and backgrounds to enhance the look of the website, and most importantly, thorough.

js-portfolio's Issues

Morning session: peer-to-peer code reviews

Morning session: peer-to-peer code reviews

You have done an excellent job so far! 💪 but there is some issue we found.

• In the contact section submit button has a hover issue
• In the header and desktop view you can hide the menu icon 🙂

Morning session: peer-to-peer code reviews

Changes to be made

Well done with the code, it was well documented and well structured, however i saw some few things that needs to be touched. In my opinion i think it would be nice if you remove the horizontal view with overflow:hidden

Morning Session: Peer to Peer Review

Hi @c00p75 ,

You did a great job working on your mobile menu! 🎆 I would suggest, in order to improve it even more, that you block the scrolling when the menu is opened. It will improve user experience tremendously. 🤓
💡 Hint: You could toggle a class on the body with JavaScript, similar to what you did with toggling the menu but adding an overflow-y: hidden property.