c0m4r/paranoya

Simple IOC and YARA scanner for Linux®

paranoya's Issues

Loki does not follow symlinks

Describe the bug
Loki does not follow symlinks

To Reproduce
Run on symlink

Expected behavior
Should follow symlinks

Additional context
os.walk has followlinks=False

Fix 2 Security issues in lib\helpers.py

CodeFactor found multiple issues:

Use of insecure MD2, MD4, MD5, or SHA1 hash function.

• lib\helpers.py:54
• lib\helpers.py:53

Call an Exorcist!

😱

Fix 'Try, Except, Pass detected.' issue in loki.py

CodeFactor found an issue: Try, Except, Pass detected.

It's currently on:
loki.py:1623-1624

Fix 'subprocess call with shell=True identified, security issue.' issue in loki.py

CodeFactor found an issue: subprocess call with shell=True identified, security issue.

It's currently on:
loki.py:851

Fix 4 Security issues in loki-upgrader.py

CodeFactor found multiple issues:

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.

• loki-upgrader.py:218
• loki-upgrader.py:211
• loki-upgrader.py:93
• loki-upgrader.py:47

Fix 4 Maintainability issues in multiple files

CodeFactor found multiple issues:

ambiguous variable name 'l'

• loki.py:1846
• loki.py:1844

Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag.

• addons\docker\void\Dockerfile:1

Delete the apt-get lists after installing something

• addons\docker\debian\Dockerfile:2

Fix 6 Complexity issues in multiple files

CodeFactor found multiple issues:

Complex Code

• loki.py

Very Complex Method

• loki.py: scan_path_files

Complex Method

• loki.py: initialize_hash_iocs
• loki.py: initialize_yara_rules
• loki-upgrader.py: update_signatures
• loki-upgrader.py: update_loki

Add a progress bar

Is your feature request related to a problem? Please describe.
For higher amounts of files scanned in oneshot it's worth adding a progress bar.

Describe the solution you'd like
Implement a progress bar

Additional context
Quick PoC

import time
import progressbar
import os

source = "/usr/share"

def file_list(source):
    matches = []
    print("Calculating... This might take a while...")
    for root, dirnames, filenames in os.walk(source, followlinks=True):
        for filename in filenames:
            matches.append(os.path.join(root, filename))
    return matches

files = file_list(source)
files_len = len(files)

with progressbar.ProgressBar(max_value=files_len, redirect_stdout=True, enable_colors=False) as bar:
    i = 0
    for file in files:
        i += 1
        print(file)
        time.sleep(0.0000001)
        bar.update(i)