Giter Site home page Giter Site logo

Comments (5)

jonasjucker avatar jonasjucker commented on August 21, 2024

ping @leclairm @mjaehn because this is a major blocker atm.

from spack-c2sm.

leclairm avatar leclairm commented on August 21, 2024

As I see it, it's only an issue on Daint, right? If yes, that would speak for freezing the Daint config and only moving to 21.x on Alps.

from spack-c2sm.

leclairm avatar leclairm commented on August 21, 2024

So after a lot of printouts, I have a start of an answer to what is happening and what looks like a workaround

My 2 cents on what happens

in the reorder_flags method, this statement node = SpecBuilder.make_node(pkg=spec.name) generates a node that seem to only consider the package name and not the rest of the spec, e.g. the compiler. In our case, it leads to including nvhpc flags provided by compilers.yaml when trying to reorder flags for cmake%gcc and gmake%gcc.

Workarounds

2 things have worked so far:

  • explicitly include ^gmake%gcc ^cmake%gcc in the spec, like spack spec [email protected]%nvhpc ^[email protected]%gcc ^[email protected] ^gmake%gcc ^cmake%gcc
  • make the package depend on gmake%gcc and cmake%gcc. So directly include depends_on('gmake %gcc') and depends_on('cmake %gcc') in /repos/c2sm/packages/pytorch-fortran-proxy/package.py

from spack-c2sm.

leclairm avatar leclairm commented on August 21, 2024

So after a lot of printouts, I have a start of an answer to what is happening and what looks like a workaround

My 2 cents on what happens

in the reorder_flags method, this statement node = SpecBuilder.make_node(pkg=spec.name) generates a node that seem to only consider the package name and not the rest of the spec, e.g. the compiler. In our case, it leads to including nvhpc flags provided by compilers.yaml when trying to reorder flags for cmake%gcc and gmake%gcc.

Workarounds

2 things have worked so far:

* explicitly include `^gmake%gcc ^cmake%gcc` in the spec, like `spack spec [email protected]%nvhpc ^[email protected]%gcc ^[email protected] ^gmake%gcc ^cmake%gcc`

* make the package depend on `gmake%gcc` and `cmake%gcc`. So directly include `depends_on('gmake %gcc')` and `depends_on('cmake %gcc')` in `/repos/c2sm/packages/pytorch-fortran-proxy/package.py`

Well I was wrong for what might be happening there. I think it's more in these lines:

sorted_sources = sorted(
    self._flag_sources[source_key], key=lambda s: order.index(s)
)

from spack-c2sm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.