Giter Site home page Giter Site logo

Comments (6)

c3mdigital avatar c3mdigital commented on July 28, 2024

Hi thanks for taking the time to submit this. Looking at the src attribute the images are missing the file extension.

<p><a href="http://pics.livejournal.com/georgedorgan/pic/0003q44e/"><img style="border-width: 0px; border-style: solid;" src="http://pics.livejournal.com/georgedorgan/pic/0003q44e/s640x480" alt="" width="640" height="143"></a></p>

The plugin uses the WordPress media_sideload_image function which requires a full url including file extension to work. Even though the images work in the browser WordPress will return the WP_Error object when it encounters the file.

from media-tools-for-wordpress.

peterkirs avatar peterkirs commented on July 28, 2024

Thanks for the quick reply. That explains a lot, why the plugin "add images to gallery" not works, but maybe also why I cannot do Wordpress XML export and import.

http://wordpress.org/support/topic/wordpress-import-creates-masses-of-duplicated-media-not-more?replies=7#post-3040465
The import actually creates lots of duplicated images.

Means anybody who migrated from Livejournal to Wordpress will not be able to use your tool.

from media-tools-for-wordpress.

peterkirs avatar peterkirs commented on July 28, 2024

HI Chris,
I added the file extension to all images in one post manually. The images got imported source attribute got correctly changed.
Unfortunately the images still link to life journal via HREF

This is an important feature which is missing in your tool: Usually when you import posts (from another blog) then both HREF and SRC point to the old blog and are equal.

This implies that in the case that HREF=SRC then you should replace both SRC and HREF by the imported image.
--> you probably do that already ?

In my case: SRC = HREF.[FileExtension]
--> you do not replace HREF

from media-tools-for-wordpress.

c3mdigital avatar c3mdigital commented on July 28, 2024

I am considering adding this feature. It would have to be via an opt in option to make sure that is what the user wants.

from media-tools-for-wordpress.

c3mdigital avatar c3mdigital commented on July 28, 2024

The issue of the missing file extension handling is being worked on for WordPress core. The bug hasn't been accepted yet but thanks to your feedback along with other users I'm going try and get it pushed through. See http://core.trac.wordpress.org/ticket/18730#comment:3 for more info.

The logical way to handle this is read the file headers and add the correct extension based on the mime type instead of relying on the extension.

from media-tools-for-wordpress.

peterkirs avatar peterkirs commented on July 28, 2024

Thank you,
I got the same issue not only with life journal, but also with imported gravatars.

from media-tools-for-wordpress.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.