caddy-dns/godaddy

godaddy's Issues

Unknown field "api_token"

I'm running Caddy 2.6.4 with the godaddy module and ran into this error.

{"error":"loading config: loading new config: loading http app module: provision http: getting tls app: loading tls app module: provision tls: provisioning automation policy 1: loading TLS automation management module: position 0: loading module 'acme': provision tls.issuance.acme: loading DNS provider module: loading module 'godaddy': decoding module config: dns.providers.godaddy: json: unknown field \"api_token\""}

I'm using the following JSON config for Caddy:

{
  "subjects": [
    "*.domain.com"
  ],
  "on_demand": false,
  "issuers": [
    {
      "challenges": {
        "dns": {
          "provider": {
            "name": "godaddy",
            "api_token": "abcedfgh"
          }
        }
      },
      "module": "acme"
    }
  ]
}

Any idea what I'm missing here? It seems api_token matches the docs correctly.

Documentation for GODADDY_TOKEN environment variable

I'm trying to use this plugin and it seems like some basic information is missing from your documentation. In Caddy V1 the code below works just fine when GODADDY_API_KEY and GODADDY_API_SECRET are set as environment variables.

The proper environment variables for this plugin for caddy V2 are not even discussed at all in your documentation or I can't find it. I'm assuming they haven't changed? Also there is use of the word Token, ex: "{env.GODADDY_TOKEN}", which doesn't match anything. What token? Go Daddy uses an API Key and a Secret.

tls {
	 dns godaddy
     }

In V2 the same code throws this error

2023/01/14 18:45:13.500 �[34mINFO�[0m   http.acme_client        trying to solve challenge       {"identifier": "REDACTED.TLD", "challenge_type": "dns-01", "ca": "https://acme-staging-v02.api.letsencrypt.org/directory"}
2023/01/14 18:45:13.504 �[34mINFO�[0m   AppendRecords REDACTED.TLD. [{ TXT _acme-challenge.<REDACTED> nZQM<REDACTED>HOEE 0s 0}]
2023/01/14 18:45:13.603 �[31mERROR�[0m  http.acme_client        cleaning up solver      {"identifier": "REDACTED.TLD", "challenge_type": "dns-01", "error": "no memory of presenting a DNS record for \"_acme-challenge.REDACTED.TLD\" (usually OK if presenting also failed)"}
2023/01/14 18:45:13.673 �[31mERROR�[0m  tls.obtain      could not get certificate from issuer   {"identifier": "REDACTED.TLD", "issuer": "acme-v02.api.letsencrypt.org-directory", "error": "[REDACTED.TLD] solving challenges: presenting for challenge: adding temporary record for zone \"REDACTED.TLD.\": could not append records: Domain: REDACTED.TLD; Record: _acme-challenge.<REDACTED>, Status: 401; Body: {\"code\":\"MALFORMED_CREDENTIALS\",\"message\":\"Unauthorized : API Key-Secret is malformed\"}; PUT: [{\"data\":\"nZ<REDACTED>EE\"}] (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/83059923/6528081103) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)"}

xcaddy in 2.6.3 breaks because of golang issue for all plugins / modules unless modules updated by maintainer

Caddy 2.6.3 is out but building it with the godaddy-dns module (affects many modules apparently) fails unless the module is updated.

Caddy dev francislavoie details the issue near the bottom of issue golang/go#56494

Linked is quic-go/quic-go#3652

Unfortunately, I'm not a Go dev. Just someone trying to update Caddy to 2.6.3 and depending upon the godaddy-dns plugin..

Raising this in the hopes that a plugin update can fix this

ERROR tls.obtain could not get certificate from issuer

I used this module and when i run caddy with my Caddyfile, i creates the _txt file alright but errors out

> 2023/11/20 15:12:16.620 ERROR tls.obtain could not get certificate from issuer {"identifier": "apps.FOO.com", "issuer": "acme-staging-v02.api.letsencrypt.org-directory", "error": "[apps.FOO.com] solving challenges: waiting for solver certmagic.solverWrapper to be ready: timed out waiting for record to fully propagate; verify DNS provider configuration is correct - last error: <nil> (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/126120754/12404642644) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)"}

my Caddyfile (redacted)

{
    # email to use on Let's Encrypt
    email [email protected]

    # Uncomment for debug
    acme_ca https://acme-staging-v02.api.letsencrypt.org/directory
    acme_dns godaddy 123456
    debug
}

apps.FOO.com {
   reverse_proxy http://192.168.11.162:8069
}

Can't build with xcaddy 0.3.2 & Go 1.20.4: `can't find reason for requirement`

export XCADDY_SUDO=0

xcaddy build \
    --with github.com/caddy-dns/godaddy

panic: internal error: can't find reason for requirement on github.com/google/[email protected]

2023/05/18 22:20:39 [INFO] Temporary folder: /Users/aj/buildenv_2023-05-18-2220.3968038451
2023/05/18 22:20:39 [INFO] Writing main module: /Users/aj/buildenv_2023-05-18-2220.3968038451/main.go
package main

import (
	caddycmd "github.com/caddyserver/caddy/v2/cmd"

	// plug in Caddy modules here
	_ "github.com/caddyserver/caddy/v2/modules/standard"
	_ "github.com/caddy-dns/godaddy"
)

func main() {
	caddycmd.Main()
}
2023/05/18 22:20:39 [INFO] Initializing Go module
2023/05/18 22:20:39 [INFO] exec (timeout=10s): /Users/aj/.local/opt/go/bin/go mod init caddy
go: creating new go.mod: module caddy
go: to add module requirements and sums:
	go mod tidy
2023/05/18 22:20:40 [INFO] Pinning versions
2023/05/18 22:20:40 [INFO] exec (timeout=0s): /Users/aj/.local/opt/go/bin/go get -d -v github.com/caddyserver/caddy/v2
go: downloading github.com/caddyserver/caddy/v2 v2.6.4
go: downloading github.com/caddyserver/caddy v1.0.5
go: downloading github.com/caddyserver/certmagic v0.17.2
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/prometheus/client_golang v1.14.0
go: downloading github.com/quic-go/quic-go v0.32.0
go: downloading go.uber.org/zap v1.24.0
go: downloading golang.org/x/sys v0.5.0
go: downloading golang.org/x/term v0.5.0
go: downloading github.com/klauspost/cpuid/v2 v2.2.3
go: downloading github.com/libdns/libdns v0.2.1
go: downloading github.com/mholt/acmez v1.1.0
go: downloading github.com/miekg/dns v1.1.50
go: downloading golang.org/x/crypto v0.5.0
go: downloading golang.org/x/net v0.7.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.2
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/prometheus/client_model v0.3.0
go: downloading github.com/prometheus/common v0.37.0
go: downloading github.com/prometheus/procfs v0.8.0
go: downloading google.golang.org/protobuf v1.28.1
go: downloading github.com/quic-go/qpack v0.4.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/golang/mock v1.6.0
go: downloading github.com/onsi/ginkgo/v2 v2.2.0
go: downloading go.uber.org/atomic v1.9.0
go: downloading go.uber.org/multierr v1.6.0
go: downloading golang.org/x/tools v0.2.0
go: downloading github.com/quic-go/qtls-go1-18 v0.2.0
go: downloading github.com/quic-go/qtls-go1-19 v0.2.0
go: downloading github.com/quic-go/qtls-go1-20 v0.1.0
go: downloading golang.org/x/exp v0.0.0-20221205204356-47842c84f3db
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading golang.org/x/text v0.7.0
go: downloading golang.org/x/mod v0.6.0
go: downloading github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0
go: downloading github.com/google/pprof v0.0.0-20210407192527-94a9f03dee38
go: added github.com/beorn7/perks v1.0.1
go: added github.com/caddyserver/caddy/v2 v2.6.4
go: added github.com/caddyserver/certmagic v0.17.2
go: added github.com/cespare/xxhash/v2 v2.1.2
go: added github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0
go: added github.com/golang/mock v1.6.0
go: added github.com/golang/protobuf v1.5.2
go: added github.com/google/pprof v0.0.0-20210407192527-94a9f03dee38
go: added github.com/google/uuid v1.3.0
go: added github.com/klauspost/cpuid/v2 v2.2.3
go: added github.com/libdns/libdns v0.2.1
go: added github.com/matttproud/golang_protobuf_extensions v1.0.1
go: added github.com/mholt/acmez v1.1.0
go: added github.com/miekg/dns v1.1.50
go: added github.com/onsi/ginkgo/v2 v2.2.0
go: added github.com/prometheus/client_golang v1.14.0
go: added github.com/prometheus/client_model v0.3.0
go: added github.com/prometheus/common v0.37.0
go: added github.com/prometheus/procfs v0.8.0
go: added github.com/quic-go/qpack v0.4.0
go: added github.com/quic-go/qtls-go1-18 v0.2.0
go: added github.com/quic-go/qtls-go1-19 v0.2.0
go: added github.com/quic-go/qtls-go1-20 v0.1.0
go: added github.com/quic-go/quic-go v0.32.0
go: added go.uber.org/atomic v1.9.0
go: added go.uber.org/multierr v1.6.0
go: added go.uber.org/zap v1.24.0
go: added golang.org/x/crypto v0.5.0
go: added golang.org/x/exp v0.0.0-20221205204356-47842c84f3db
go: added golang.org/x/mod v0.6.0
go: added golang.org/x/net v0.7.0
go: added golang.org/x/sys v0.5.0
go: added golang.org/x/term v0.5.0
go: added golang.org/x/text v0.7.0
go: added golang.org/x/tools v0.2.0
go: added google.golang.org/protobuf v1.28.1
2023/05/18 22:20:58 [INFO] exec (timeout=0s): /Users/aj/.local/opt/go/bin/go get -d -v github.com/caddy-dns/godaddy github.com/caddyserver/caddy/v2
go: downloading github.com/caddy-dns/godaddy v1.0.2
panic: internal error: can't find reason for requirement on github.com/google/[email protected]

goroutine 1 [running]:
cmd/go/internal/modget.(*resolver).updateBuildList.func1({{0xc0005b1aa0, 0x17}, {0xc0000309c0, 0x22}})
	/usr/local/go/src/cmd/go/internal/modget/get.go:1760 +0xd4
cmd/go/internal/modget.(*resolver).updateBuildList(0xc0000aa000, {0x17465f8, 0xc00002c0b0}, {0x0, 0x0, 0x0})
	/usr/local/go/src/cmd/go/internal/modget/get.go:1765 +0x54c
cmd/go/internal/modget.(*resolver).resolveQueries(0xc0000aa000, {0x17465f8, 0xc00002c0b0}, {0xc000065860, 0x2, 0xc00010dd70?})
	/usr/local/go/src/cmd/go/internal/modget/get.go:1243 +0x1b1
cmd/go/internal/modget.runGet({0x17465f8, 0xc00002c0b0}, 0xc000026528?, {0xc000022220, 0x2, 0x2})
	/usr/local/go/src/cmd/go/internal/modget/get.go:314 +0x408
main.invoke(0x1a61260, {0xc0000221f0, 0x5, 0x5})
	/usr/local/go/src/cmd/go/main.go:225 +0x3d9
main.main()
	/usr/local/go/src/cmd/go/main.go:179 +0x7ce
2023/05/18 22:21:23 [FATAL] exit status 2

readme error

"name": "goddady", -> "name": "godaddy",