cadespres/spring-petclinic-migration

A sample Spring-based application

Spring PetClinic -- Rewrite Technical Debt Remediation Sample

This is an example project that shows how to get started with Rewrite to automatically perform framework migrations and eliminate technical debt! The default branch (1.5.x) contains a slightly messier form of the last modification made to the famous Spring PetClinic sample in the Spring Boot 1.5.x line. You'll see how to apply Rewrite to tidy up some of this code. As we add additional Rewrite recipes, you'll eventually be able to see this sample app automatically migrated to the latest Spring Boot 2.x version including dependencies!

What does Rewrite do?

Rewrite works by making changes to special abstract syntax trees (AST) of your source code and printing out those modified trees back into your repository for you to review the changes and commit. Modifications to the AST are performed in visitors and visitors are assembled into profiles. We call the combination of visitors and profiles a Rewrite recipe. Rewrite recipes make minimally invasive changes to your source code that honors the original formatting.

For example, a Mockito 1 to Mockito 3 recipe consists of a mockito profile that includes a number of individual visitors that fix individual breaking API changes that were made between Mockito 1 and Mockito 3.

In this example, we'll craft a custom JUnit recipe with a single visitor that will refactor any JUnit assertXXX(..) calls to use static imports.

Instructions

First, clone this repository. If you'd like to skip ahead to running the fixes, checkout the tutorial branch, which is pre-configured and ready to run.

Adding a custom JUnit recipe

Add a rewrite.yml file to the root of the repository with the following contents:

type: beta.openrewrite.org/v1/visitor
name: junit.StaticJUnitAsserts
visitors:
  - org.openrewrite.java.UseStaticImport:
      method: org.junit.Assert assert*(..)
---
type: beta.openrewrite.org/v1/profile
name: junit
include:
  - junit.StaticJUnitAsserts

This single YAML file contains two YAML documents: a declarative Rewrite visitor and a profile that includes that visitor. The visitor is defined with type beta.openrewrite.org/v1/visitor and given a name. Generally, group the visitors for a recipe under some common prefix (in this case junit.). Effectively, this is a custom visitor that delegates to a building-block visitor (org.openrewrite.java.UseStaticImport) that Rewrite provides out of the box. We're specifying that any method call to the receiver type org.junit.Assert whose method name begins with assert should use a static import.

So we're changing

import org.junit.Assert;
...

Assert.assertTrue(condition);

to

import static org.junit.Assert.assertTrue;
...

assertTrue(condition);

The building-block visitor UseStaticImport is smart enough to know how to remove the old import if it is no longer used, add a new static import, and collapse several static imports of org.junit.Assert into a single static star import (import static org.junit.Assert.*) if the right number of imports is reached and vice versa.

The profile is defined in another YAML document with type beta.openrewrite.org/v1/profile. It's given a name junit that we will use to activate this recipe in our pom.xml. The profile explicitly includes our new custom visitor.

Adding the Rewrite Maven plugin

Next, add the Rewrite maven plugin to your pom.xml:

<plugin>
    <groupId>org.openrewrite.maven</groupId>
    <artifactId>rewrite-maven-plugin</artifactId>
    <version>1.2.1</version>
    <configuration>
        <activeProfiles>spring,mockito,junit</activeProfiles>
        <configLocation>rewrite.yml</configLocation>
    </configuration>
</plugin>

The maven plugin packs with a default set of recipes that can be activated at will. In this case, we're activating the spring and mockito profiles along with our custom junit profile.

Running the fixes

Run ./mvnw rewrite:fix to run the recipes, which will make changes to the source code of the repository. In a real-world scenario, you'd review these changes and perform whatever checks you'd like and then commit them when you are comfortable that they are accurate. The set of recipes that are provided for you by Rewrite are intended to always produce 100% accurate fixes that don't require any manual intervention.

Run git diff to see the changes

The diff shows how, among other changes, Rewrite has removed unnecessary @Autowired annotations from injectable constructors (which is now implicit in Spring Boot) and swapped the @RequestMapping annotation for @GetMapping, closing a CSRF security vulnerability (!!).