calebporzio/gitdown

A simple package to parse Github Flavored Markdown in PHP

gitdown's Issues

Footnote links are not working.

The code that is generated for footnotes links is incorrect and causes the links to not work. The link to the footnote is generated like this:

<sup><a href="#fn-1" id="user-content-fnref-1">1</a></sup>

The footnote is like this:

<li id="user-content-fn-1">
    <p>
        First footnote
        <a href="#fnref-1">
            <g-emoji class="g-emoji" alias="leftwards_arrow_with_hook" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/21a9.png">↩</g-emoji>
        </a>
    </p>
</li>

The href attribute of the link to the footnote does not match the target id attribute of the footnote <li> element. Also, the href attribute of the return link does not match the target id attribute of the footnote link.

If the footnote link is changed from

<sup><a href="#fn-1" id="user-content-fnref-1">1</a></sup>

to

<sup><a href="#user-content-fn-1" id="fnref-1">1</a></sup>

it works.

I have checked this directly in GitHub and the footnotes work there but not with HTML generated through GitDown.

How to prevent HTML escaping

First of all, thank you for this amazing package 🙌

I'm already using it in my personal website. The process was smooth and the result is really great.

The only issue I'm having is when I try to embed tweets. You can check it here

I searched for a while but can't find anything useful. Maybe it's not even possible.

I already have the allowIframe option set to true.

Thank you,

David

Class GitDown not found after update from Laravel 9 to 10

I've updated my website from Laravel 9 to 10 after which your package is broken.
In my v9 composer.json I had version 1.3 ("calebporzio/gitdown": "^1.3") but after the update this was downgraded to "calebporzio/gitdown": "^1.1" due to the guzzlehttp/guzzle package being updated to v7 while your package requires v6 (or so it seems)

Script tag not working when parse html

Hello,

Script tag not working when parse html.

Can you please guide what is wrong in code.

Inserted code in editor:

Codepen Embed

<script async src="https://static.codepen.io/assets/embed/ei.js"></script>

Output:

Codepen Embed

<script async src="https://static.codepen.io/assets/embed/ei.js"></script>

Zttp is locked to an old Guzzle

I don't know how enthusiastic Adam is about the prospect of updating zttp to use Guzzle 7. Since you actually only use Zttp in one isolated method and everything could very easily be done using Guzzle or even Curl instead, does it maybe make sense to drop Zttp as a dependency and just reach down a level?

I only noticed this because I was going to use this package as a shortcut on a Laravel 8 project. I could go any one of a dozen different ways to solve this problem. But I figured I'd bring this to your attention to see if you'd like to do something here. If so I'll happily send a PR ripping out Zttp and replacing it with Guzzle (requiring 6 or 7).