callum-rhodes/gabp_mapping

Gaussian belief propagation solver for generating gas distribution maps in both 3D and 2D

gabp_mapping's Issues

typo

gabp_mapping/scripts/throttlePID.py

Lines 11 to 12 in a8d0f12

	topic_type = rospy.get_param('~topic_type', 'Int32')
	rospy.loginfo('Ouputting on topic: {}'.format(out_topic))

rospy loginfo is mistaken

Counter initialization in Integrator

gabp_mapping/scripts/throttlePID.py

Lines 38 to 53 in a8d0f12

	def getIntegratedValue(self):
	t_now = rospy.get_time()
	t_delta = 0.
	i = 1
	summer = 0.
	while t_delta < self.integration_period and i != len(self.data_store):
	summer += self.data_store[-i]
	t_delta = t_now - self.time_store[-i]
	i += 1
	val = float(summer) / i
	trunc = len(self.data_store) - i
	del self.data_store[:trunc]
	del self.time_store[:trunc]
	return val

Should initialization be i=0 rather than i=1?

TabError: inconsistent use of tabs and spaces in indentation

TabError

Traceback (most recent call last):
  File "/home/nuci7/gabp/devel/lib/gabp_mapping/main_2D.py", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/home/nuci7/gabp/src/gabp_mapping/scripts/main_2D.py", line 113
    rospy.on_shutdown(GaBP_k.on_shutdown)
                                        ^
TabError: inconsistent use of tabs and spaces in indentation
Traceback (most recent call last):
  File "/home/nuci7/gabp/devel/lib/gabp_mapping/throttlePID.py", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/home/nuci7/gabp/src/gabp_mapping/scripts/throttlePID.py", line 29
    if topic_type == 'Float32':
                              ^
TabError: inconsistent use of tabs and spaces in indentation