caltechlibrary/commonpy

Collection of common Python utility functions and classes used in other Caltech Library programs.

commonpy's Issues

simple net usage has unexpected results

Describe the bug

With just a method and a url for net(), there is no result and a ValueError. I am able to get a result with cURL.

To Reproduce

from commonpy.network_utils import net
print(net('get', 'https://caltech.tind.io/search?ln=en&p=barcode%3A+35047019492099&of=xm'))

result:
(None, ValueError('httpx.Timeout must either include a default, or set all four parameters explicitly.'))

Environment (please complete the following information)

• Operating system: macOS 10.15.7
• Version of Python: 3.9.1

Additional context

cURL can return the expected XML:
curl -H "Accept: application/xml" -H "Content-Type: application/xml" -X GET "https://caltech.tind.io/search?ln=en&p=barcode%3A+35047019492099&of=xm"

Remove repeated http status testing code in network_utils.py

The new download code in network_utils.py has some repetition of status testing code. We should keep it DRY and abstract that out into a common function used by net.

Support multiple signals in `config_interrupt`

config_interrupt only supports handling a single signal. It would be useful to make it handle more. See this Stack Overflow answer for some ideas.

Add feature request & pull request templates

Describe the bug

This repo now has an issue template, but not a feature request or pull request template.

Additional context

I'm using this bug report form to report this as an issue, although this is actually a feature request and not a bug per se.

Do proper documentation

This package sorely needs a proper documentation site, at least as a github.io site if not ReadTheDocs.

Network utilities don't handle IPv6 addresses

The network utilities all assume IPv4 addresses and break badly for IPv6.

Rewrite files_in_subdirectory(...)

1. Use os.scandir()
2. Detect infinite recursion in subdirectories. See https://stackoverflow.com/a/36977656/743730 for an idea of how.