camptocamp/wal-g-prometheus-exporter

Export prometheus metrics for wal-g backup tool

wal-g-prometheus-exporter's Issues

AttributeError: 'NoneType' object has no attribute 'timestamp' in `last_xlog_upload_callback`

Potential bug?

Our exporter has worked fine for months, and a few days ago it started emitting logs like this one:

Traceback (most recent call last):
AttributeError: 'NoneType' object has no attribute 'timestamp'
 File "exporter.py", line 239, in last_xlog_upload_callback
 File "prometheus_client/metrics.py", line 420, in samples
 File "prometheus_client/metrics.py", line 213, in _samples
 File "prometheus_client/metrics.py", line 220, in _multi_samples
 File "prometheus_client/metrics.py", line 94, in collect
 File "prometheus_client/registry.py", line 83, in collect
 File "prometheus_client/openmetrics/exposition.py", line 22, in generate_latest
 File "prometheus_client/exposition.py", line 104, in _bake_output
 File "prometheus_client/exposition.py", line 122, in prometheus_app
 File "wsgiref/handlers.py", line 137, in run

i.e. here:

wal-g-prometheus-exporter/exporter.py

Line 238 in b5a0a46

return archive_status['last_archived_time'].timestamp()

(I have different line numbers, due to us using this fork with the changes from #3: https://github.com/pagero/wal-g-prometheus-exporter)

Alternative to SIGHUP for recurringly updating metrics for basebackups

Since Kubernetes doesn't support sending signals (i.e. SIGHUP) to pods/containers, it would be nice being able to trigger/schedule updates of metrics related to basebackups

Related to this in the current implementation:

wal-g-prometheus-exporter/exporter.py

Lines 296 to 300 in b5a0a46

	# Launch exporter
	exporter = Exporter()
	# listen to SIGHUP signal
	signal.signal(signal.SIGHUP, exporter.update_basebackup)

&

wal-g-prometheus-exporter/exporter.py

Lines 162 to 166 in b5a0a46

	def update_basebackup(self, *unused):
	"""
	When this script receive a SIGHUP signal, it will call backup-list
	and update metrics about basebackups
	"""

What do you think?

Enable use of wal-g config file

Hi,

i am interested in exporting metrics from a wal-g instance that streams the arhive to S3 and uses a config-file similar to:

{
  "WALG_S3_PREFIX": "s3://",
  "AWS_ACCESS_KEY_ID": "",
  "AWS_SECRET_ACCESS_KEY": "",
  "AWS_ENDPOINT": "",
  "AWS_S3_FORCE_PATH_STYLE": "true",
  "WALG_S3_CA_CERT_FILE": "",
  "PGPASSWORD": "",
  "PGHOST": "",
  "PGPORT": 5432
}

And run as wal-g --config /x/y/z.json backup-list.

It would be very useful to be able to specify the same config to the exporters. Currently i am getting an error when the exporter runs wal-g backup-list...

Might be even worth using the wal-g config as input for the exporter..?