Comments (7)
This guide is great and has instilled courage and confidence in me. I'd like to give it a go!
from metric_units_reddit_bot.
@criticsquid Sorry for the delay! Reading the guide and will submit my pull request soon, I'll let you know if I have any issues.
from metric_units_reddit_bot.
@pdbeard Sure! Go for it. Let us know if you run into any issues or need any pointers :)
from metric_units_reddit_bot.
Yay @pdbeard !!!!!!!!!!1 :D
from metric_units_reddit_bot.
Thanks @citricsquid and @cannawen!
I've set up the project and received one "pending" status on the initial test run. Is this expected?
Current failing tests - bugs and edge cases
- should display partial inches
Additionally, I noticed one other test that passed, but returned a warning.
on trigger
✓ should refresh network token
(node:10112) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 uncaughtException listeners added. Use emitter.setMaxListeners() to increase limit
✓ should get all unread messages
All the others passed. I'm on node v7.10.1. Thoughts?
from metric_units_reddit_bot.
@pdbeard a test can be written but skipped if the functionality hasn't been built yet, on line 506 of test/converter-test.js
is what is causing the pending
test notice, which is expected.
context.skip('Current failing tests - bugs and edge cases', () => {
//Story #150482058
it('should display partial inches', () => {
testConvert("9 feet 10.5", { "9'10.5\"": "3.01 metres" });
});
});
The MaxListenersExceededWarning
error isn't something you need to worry about it, it's just because by default nodejs limits to 10 listeners to prevent memory leaks and we haven't explicitly upped that limit yet.
You should be able to proceed with development! :)
from metric_units_reddit_bot.
@pdbeard Hey! I noticed you committed your changes to your fork but did not submit a pull request here. Do you need help with that? A pull request is required to have your changes added to this repository :)
Here's a GitHub guide on submitting a pull request: https://help.github.com/articles/creating-a-pull-request/
from metric_units_reddit_bot.
Related Issues (20)
- Refactor number parsing HOT 1
- Bug report: Add ignore keywords to "cups" for gaming sub reddits
- Feature request: Add unit `qt` = 1/4 gallon HOT 3
- Range conversion "30-50lb" converted to "30 lb50 lb ≈ 1423 kg"
- Scan the r/homebrewing thread and post constructive feedback in r/metric_units HOT 2
- Move documentation to /docs folder HOT 5
- bot off HOT 1
- Discussion - Discussions HOT 2
- Handle commas better HOT 16
- Always add L/100km conversion
- "oz" is not being converted to "troy oz" in subreddit /r/Pmsforsale HOT 27
- Ignore all nba subreddits for mpg HOT 10
- Ignore "cup" measurements over 100 HOT 2
- Feature request: Convert lbs/inch to kg/mm and N/m HOT 4
- Handle close numbers better HOT 1
- Conversions architecture overhaul
- Modify pressureMap to convert 10^5 pa to bar HOT 4
- Improve rounding HOT 4
- change footer links and text HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metric_units_reddit_bot.