discoverNode() should inform listeners if new node is not exactly the same as previously discovered node with same IP

[cansik]

discoverNode() should inform listeners if new node is not exactly the same as previously discovered node with same IP

[cansik]

hey @alamaral, thank you very much for the issues you have opened and the problems you have described. This library is a fork of the old ArtNet4J project which once was hosted on google code, adding just some more functions. There are (as you experienced) a lot of issues within library, if you dig a bit deeper. That is why others have started to re-implement the artnet library with a better structure and less buggy behaviour. For example @schw4rzlicht has started to implement a library some years ago which seems to be pretty mature now deltaeight/LibArtNet.

To be honest, I am not sure if I am going to work on these issues any time soon. But the community and I would of course be happy if you would have the time to add a pull request (as you already supplied some of the code which would solve the issue). I would be happy to merge them and release a new version.

[alamaral]

Thanks. I had originally found a different fork of artnet4j about 4 years ago, and used that in our product, but it hasn't been touched for ages. I came across your fork which had some new functionality we needed, so started testing it. We recently got a new DMX controller (Swisson XND-4) which had brought these bugs to light and I figured it wouldn't hurt to file the bugs.

I did see LibArtNet, but it too hasn't been touched in 2 years, and I didn't want to have to port to a new library with different bugs, so I stayed with artnet4j, as it worked well enough for our purposes. I'll take another look at LibArtNet to see just how mature it is. If it doesn't work out I may end up creating a new fork for artnet4j and trying to maintain it myself.

Thanks again for your work.