ArtNetServer blocks when used as sender

[schw4rzlicht]

ArtNetServer blocks when used as sender

[cansik]

It would be nice if you could test, if the stop method now works as expected.

Here is the new compiled binary if you need it:
artnet4j.zip

[schw4rzlicht]

That did the trick.

Regarding the refactor: I might do this (at least for the sender part) because the current API unnecessarily bloats my project with a new thread. If I do it in the near future, I'd fork and create a pull request.

[cansik]

To the first question about the start and stopping, that is totally true. The problem is that the underlaying framework is still the "old" artnet4j code and needs a lot of refactoring. Yes the approach with closing the socket is a good idea and I will implement it in the next version (already fixed it now).

The second question is something that bothers me too. But for this I think I have to fully refactor the underlaying ArtNetServer class which is handling the networking. It is currently server and client which is not really useful. It would be better to create an ArtNetServer for receiving data and an ArtNetClient for sending data.

Currently the ArtNetClient is more a decorator / wrapper for the ArtNetServer which makes the API simpler. This would then be useful for both, the new ArtNetServer and ArtNetClient.

Because a lot of people are used to the old artnet4j API, I just added some fixes, but did not a complete refactoring of the framework. Maybe it would make sense to do so.