capricorn86/happy-dom

A JavaScript implementation of a web browser without its graphical user interface

happy-dom's Issues

Parsing SVG xml with no endtag will generate incorrect HTML

Two xml sibling tags with no endtag could look like this when parsed:
<path/> <path/>
But when innerHTML is generated, they will suddenly have a parent-child relationship:
<path> <path></path> </path>

Add unit tests

[bug] HTMLUnknownElement is missing

HTMLUnknownElement is uncommonly used, but it's important sometimes, such as
https://github.com/EasyWebApp/WebCell/blob/c3adfc711bbb472c4194609536b212a52d7c02a3/source/utility.ts#L73

happy-dom 0.11.0+ lost it...

Print release notes between versions

Query selector returns elements that starts with a class name when they are not equal

Create release build job not working

Wrong links in documentation

The input Element is a self closable tag, but happy-dom wants a close tag

Using sizzle for querySelectors?

Sizzle is a selector engine used by jQuery. It was there before querySelectorAll and similar methods. Now, it uses querySelectorAll if available.

I've seen there are changes in happy-dom selectors on v1.0.0 branch, but maybe it's still valuable to use Sizzle? I gave it a quick try with happy-dom, but unfortunately, Sizzle expects window object to be available. We could experiment with it further (I think even contributing in Sizzle isn't a problem), but the question is - is this worth it? What do you think?

No text node is created when there only is one character

DOMTokenList.add bug that allows adding tokens that contains HTML space characters

I have a function that uses the classList to add/remove class names.
I mistakenly added a two classes as one string with a space to separate them, the test PASSED but in production it failed:
"Uncaught DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('a b') contains HTML space characters, which are not valid in tokens"

//func.js
export function applyClassName({
	oldValue,
	newValue,
	element,
	defaultValue = ""
}) {
	if (newValue) {
		if (oldValue) {
			element.classList.remove(oldValue);
		}
		element.classList.add(newValue);
	} else if (oldValue) {
		element.classList.remove(oldValue);
		element.classList.add(defaultValue);
	}
}

//func.test.js
import { Window } from "happy-dom";
import { applyClassName } from "./func";

const window = new Window();
const document = window.document;

test.only("Test space within class name", () => {
	const myDiv = document.createElement("div");
	applyClassName({newValue: "a b", element: myDiv});
	expect(myDiv.className).toBe("a b");
});

I expect the test to fail because it will throw an exception, but using happy-dom it dosen't, it passes.

Semver package not found

Update documentation

Self closed elements in HTMLElementRenderer should match HTMLParser

Update documentation

Add support for hasAttribute and improve attributes property

Fix release notes build

Add ChildNode.remove()

https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove

Change publish access to public in Lerna

HappyDOM does not have support for nextElementSibling and previousElementSibling

Update documentation

Add support for requestAnimationFrame and cancelAnimationFrame

Update node-fetch

Not possible to publish scoped packages

React issue

Running tests for enhook, getting the following.

# react
(node:5736) UnhandledPromiseRejectionWarning: TypeError: Right-hand side of 'instanceof' is not an object
    at getActiveElementDeep (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:8903:18)
    at getSelectionInformation (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:8934:21)
    at prepareForCommit (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:9447:26)
    at commitRootImpl (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:24973:5)
    at unstable_runWithPriority (C:\projects\enhook\node_modules\scheduler\cjs\scheduler.development.js:818:12)
    at runWithPriority$2 (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:12130:10)
    at commitRoot (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:24889:3)
    at finishSyncRender (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:24296:3)
    at performSyncWorkOnRoot (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:24274:9)
    at scheduleUpdateOnFiber (C:\projects\enhook\node_modules\react-dom\cjs\react-dom.development.js:23665:7)
(node:5736) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)

Not sure what's the reason, due to incredibly obscure nature of react I can't even figure out where the error is coming from.
I'll just leave it here in hope somebody else will stumble upon it too, with less vague context.

Add support for ResizeObserver

slot element is null when querying it with '>'

when trying to get the slot element I receive null!

//<div class="card-footer"><slot name="footer"></slot></div>
console.info(`${this.shadowRoot.querySelector(".card-footer")}`);// => the div element
console.info(`${this.shadowRoot.querySelector(".card-footer > slot")}`);// => null
console.info(`${this.shadowRoot.querySelector(".card-footer slot")}`);// => the slot element

CustomEvent is missing detail

For some weird reason CustomEvent is the same object as Event, but looking at the code they are different. CustomEvent has detail in it and extends Event.

This was found in jest-environment-happy-dom, so it might not happen when only using happy-dom.

Reduce possible namespace conflicts with Angular SSR

Custom element attributeChangedCallback is being called on any attribute change

The callback attributeChangedCallback is being called on ANY attribute change, not only on the observed ones as expected.

here is a jest test to help you reproduce

import { Window } from "happy-dom";

class MyElem extends HTMLElement {
    attributeChangedCallback(attribute, oldValue, newValue) {}
    static get observedAttributes() {
        return ['my-attr'];
    }
}

const window = new Window();
const document = window.document;
let myElem;

window.customElements.define("my-elem", MyElem);

beforeEach(() => {
  document.body.innerHTML = "<my-elem id='my-elem'></my-elem>";
  myElem = document.querySelector("#my-elem");
});
describe("Make sure component is created", () => {
  //SUCCESS
  test("’Make sure <my-elem> is defined", () => {
    expect(myElem).not.toBeNull();
  });
  //SUCCESS
  test("’Make sure changing an observed attribute will triiger change callback", () => {
    const spy = jest.spyOn(myElem, 'attributeChangedCallback');
    myElem.setAttribute("my-attr", "css-class");
    expect(spy).toHaveBeenCalled();
  });
  //FAILS
  test("’Make sure changing non observed attribute will not triiger change callback", () => {
    const spy = jest.spyOn(myElem, 'attributeChangedCallback');
    myElem.setAttribute("class", "css-class");
    expect(spy).not.toHaveBeenCalled();
  });
  //FAILS
  test("’Make sure changing non observed attribute will not triiger change callback", () => {
    const spy = jest.spyOn(myElem, 'attributeChangedCallback');
    myElem.setAttribute("style", "display: block;");
    expect(spy).not.toHaveBeenCalled();
  });
  //FAILS
  test("’Make sure changing non observed attribute will not triiger change callback", () => {
    const spy = jest.spyOn(myElem, 'attributeChangedCallback');
    myElem.setAttribute("id", "other-id");
    expect(spy).not.toHaveBeenCalled();
  });
});

HappyDOM does not have support for mediaMatch()

Add Node.removeChild()

https://developer.mozilla.org/en-US/docs/Web/API/Node/removeChild

Release build

Logo is broken

HappyDOM does not have support for HTMLInputElement.prototype.checkValidity()

Slotchange event is not triggered automatically

Add support for click() on HTMLElements

Add integration test for Vue

Missing ParentNode APIs?

I can't find a mention of firstElementChild in this repository, which is defined in the ParentNode interface. Is this supported by happy-dom?

Release of v1.0.0

In some cases all child elements gets the same attribute

This is a really weird one. Not sure if it is a bug or if there is something wrong in the app itself.

CustomEvent class does not take type and options to the constructor

Generate release notes split error

global.Error is undefined when attempting to set global.Error.stackTraceLimit in Jest

Version is vv

Event does not support preventDefault() and stopPropagation()

Release build not working

Add support for querying *

Improved SVG support

Classes should implement "Native" types

The class "HTMLElement" should implement the official Typescript "HTMLElement" e.g. because of two reasons:

1. They can be used were native types are used (e.g. declared arguments)
2. We ensure that they implement the same propeties/methods