cardano-foundation/cardano-explorer-app

Cardano Explorer App

cardano-explorer-app's Issues

Change Ended At to Last Block At in epoch list

The API expresses the model correctly Epoch.lastBlockAt

Header background visual, animation and static image variant

The specified backgrounds:

... are not currently implemented. The animation was causing performance issues so was initially replaced with a screen shot, but has since been removed in #136 since it was just a placeholder.

The suggestion from @DominikGuzei is to render the animation as a video, and then use a static image in the smaller footprint mode.

Fix transaction info component on smaller screen sizes

The TransactionInfo component looks broken when the window size is too small:

Loading more items in the homepage feeds

Pagination is ideally naturally handled with Cardano GraphQL using a combination of limit, offset, and sort order, however with the current performance limitation we must select by number range.

Instead of referring to the NetworkInfo.store.currentEpoch, the starting point for generating the range should be determined by referencing the store array.

Import specific lodash libraries

Not sure if tree-shaking is part of the framework

import { get } from 'lodash';

import { get } from 'lodash.get';

Fix style issues

@a-rukin has identified the following style issues:

• "Show more" button hover and pressed states are wrong - https://zpl.io/V1840MJ reference

• Footer: “Open source” link should have same hover effect as an email link

• Block search result: Padding before “transactions” is missing

• Transaction search result: Padding before “transactions” is missing. Plus in this case (tx overview) transaction hash shouldn’t be a link as it leads to the page we are currently viewing

• Amounts should never go multi lines:
  

• Epochs progress ring mixes color from both themes:
  

• Fix home page header image (visible diff between bg color)

Sub pages are not linking to home page

Clicking the cardano logo in the top left should link to the home page

Support multiple APIs with the existing feature set

We're now in a position to build in support for the Jörmungandr node API as it's feasible to maintain two variants with the app development slowing down. This serves as contingency if the Jörmungandr write service for Cardano GraphQL cannot be achieved.

Extract lovelacesToAda to cardano-js

It's a simple function, but makes sense to move it to the generic library, as we'll be using it anyway

Implement Block.nextBlock

This has been implemented in Cardano GraphQL, but is unreleased.

Load homepage feed delta instead of blindly querying for the same data that's not changing

When the network indicates a change, only the missing blocks or epochs should be fetched

Invalid address summary query

https://github.com/input-output-hk/cardano-explorer-app/blob/develop/source/features/search/api/searchForAddress.graphql#L19-L31

    transactions_aggregate (
        where: {
            outputs: {
                address: {
                    _eq: $address
                }
            }
        }
    ) {
        aggregate {
            count
        }
    }

should be:

    transactions_aggregate (
        where: {
            _or: [{
                inputs: {
                    address: {
                        _eq: $address
                    }
                }
            }, {
                outputs: {
                    address: {
                        _eq: $address
                    }
                }
            }]
        }
    ) {
        aggregate {
            count
        }
    }

Link homepage feed items to detail pages

1. block number -> block page
2. epoch number -> epoch page

Fix Epoch.blocks from querying all records

Right now all the Epoch blocks are fetched

https://github.com/input-output-hk/cardano-explorer-app/blob/afb2f8efdc3828ba5dea5041190e4d1c8e1bbc7a/source/features/epochs/api/EpochDetails.graphql#L6

Once #105 is done, the AllBlocks component can be implemented here.

Blocks aggregate count is including the EBB

In Ouroborus Classic there are (k * 10) + 1 blocks in an epoch, but by convention the EBB is usually ommitted from counts etc. The aggregate count should omit this by filtering out blocks with a null number

Remove header animation

Replace it with a static rendering of the Medusa animation.

Replace Epoch block 'show more' button with paginated component

Consolidate IBlockInfo with IBlockOverview

IBlockInfo is an unnecessary vague abstraction

Make polling factor an ENV

The fetchDynamicInfo polling factor is hard coded as double the slot duration. The intention was half, so rather than update the calc, we should define an ENV that defaults to 1. This way the UI can be tweaked to gain control over the nearness of the real-time features.

Epoch percentage UI element

The Epoch percentage UI element must be calculated on the client, extending the dynamic query to fetch the current slot. See detail in

cardano-foundation/cardano-graphql#60

Use slotWithinEpoch not slotNo in BlockInfo

The detail view might want to show the globally unique slot number, but for the list view it should be scoped to the epoch

Lovelaces need to be converted to Ada

It's a client-side translation to represent Lovelaces as Ada, but right now they are displayed without the conversion.

Latest block slot number is referencing the size property

Block.slotNo needs to be checked for validity. It was added to the database recently, and may not have been included in the original tests as the preference was Slot.number

Check Block number: 3308908. The slot 1323 supposedly came after 634

EDIT: Likely just a stubbed value used and not updated to slotNo
https://github.com/input-output-hk/cardano-explorer-app/blob/develop/source/features/blocks/ui/BlockList.tsx#L24

Update this

Refresh block list on current epoch details page when network block height increases

The current epoch should share the same logic as the homepage latest blocks, inheriting the live updating when new blocks are created

Last block at in latest epoch row needs to be refreshed

When a new block is added to the latest blocks list, we also need to patch the last block at value in the current epoch row.

Refine Block.createdBy display

• Epoch boundary slot leader -> EBB
• Ensure Genesis is included

Code upgrade to use latest TS optional chaining synatax

It would be good to do a quick pass over the codebase and upgrade any old cases of guarding

Improve Browsing UX

@rhyslbw identified a few issues with the browsing feature:

Params validation

There's a bug with the browse-* pages when the total of items is less than the page qty (eg epochs in the dev data set). It triggers an endless loop:

Drop redirect because it breaks browser navigation

Need to drop the redirect to the "correct" url and just infer the corrected details from the given prams (this is already possible with the current logic)

Searching for the genesis returns a no result

{
  blocks(where: {id: {_eq: "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb"}}){
    id
    slotNo
    slotWithinEpoch
    previousBlock {
      id
      number
    }
    transactions_aggregate {
      aggregate {
        count
      }
    }
  }
}

{
  "data": {
    "blocks": [
      {
        "id": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb",
        "slotNo": null,
        "slotWithinEpoch": 0,
        "previousBlock": null,
        "transactions_aggregate": {
          "aggregate": {
            "count": 14505
          }
        }
      }
    ]
  }
}

Use Block.epochNo in TransactionDetailsFragment

https://github.com/input-output-hk/cardano-explorer-app/blob/develop/source/features/transactions/api/TransactionDetails.graphql#L3-L5

Enable MobX strict mode

Transaction input address links not working

Transaction confirmations

confirmations = NetworkInfo.blockHeight - transaction.block.number + 1

TransactionInfo is missing from TransactionSearchResult component

Expected:

Actual:

Fix issues related to epochs

Epochs Overview

For epoch overview we shouldn’t have “show more” as we are already on the “show more” step. Here we should have paginator https://zpl.io/25yl840 (amount of results is not yet decided… I guess it would be something like 25 or 50)

Browse Epochs

Epoch show more shows only 6 rows per page… let’s use at least 25 or 50

Do not link to same epoch page

Fix randomly broken style loading in dev mode

Currently the styles are randomly breaking in dev mode … that's a known issue with a specific webpack bug and next.js - this can be fixed in development with a workaround.

Refactor transaction components

The current implementation was done with some modelling errors that have manifested into a component that's unusable without rework.

1. Refactor the app models using the API models as guidance
2. Update the components to use inputs and outputs (currently represented as senders and receivers).

Footer links are stubbed

Show more items should not be visible if full result set already shown

The app should probably be pre-caching the next page anyway, or at the very least n+1 to know if it has more than what fits in the current view

Stake distribution, a Shelley-relevant feature, is showing in Byron version

Finish search no results component

Currently this is just placeholder text

Only show no results component after results have been fetched

Currently the no results component sometimes flashes in although the search result is still being fetched.

Search for address summary

Cardano GraphQL does not have an "address summary" query, as this is an application concept. Instead it offers a natural model to get the information that is what the explorer considers as Address Summary.

query searchForAddressSummary(
  $address: String!
) {
  utxos_aggregate (
    where: {
        address: {
            _eq: $address
        }
    }
  ) {
     aggregate {
         sum {
             value
         }
    }
  }
  transactions_aggregate (
      where: {
          outputs: {
              address: {
                  _eq: $address
              }
          }
      }
  ) {
      aggregate {
          count
      }
  }
}

Assigning empty Block.slotNo to 0 is invalid

https://github.com/input-output-hk/cardano-explorer-app/blob/ec1281ab9f1664edc64eabcf37245c5e5b537b2b/source/features/blocks/api/transformers.ts#L12

https://github.com/input-output-hk/cardano-graphql/blob/develop/src/schema.graphql#L251-L254

Epoch and block queries needs to be a selection using the present chain state

cardano-foundation/cardano-graphql#52

Invalid links in the block table when viewing the Epoch details

These links are not valid, since it leads to the same page.

All blocks and epochs pages with pagination

The Index load more buttons should take the user to pages that contains the same table with pagination active, enabling browsing through the chain.

Refactor data transformers to API

We should introduce API methods that transform the received data to be consumable by the app … currently we do that within the stores and that's actually not very smart (e.g it wouldn't allow us to switch to another API implementation easily)

Refine 'null' presentation

Some blocks were not created in slots, and do not have numbers. Instead of null, show -

Update address query to handle transaction result sets greater than 100

The current query makes no attempt to handle addresses which exceed the default limit of 100 (enforced by Hasura). A limit and offset argument should be supplied